Skip to content

[Modules] Storage Accounts : Add SFTP feature to storage account module # 2378#2514

Merged
karthikvenkat17 merged 27 commits intoAzure:mainfrom
karthikvenkat17:kavenka-sftp-feature
Dec 30, 2022
Merged

[Modules] Storage Accounts : Add SFTP feature to storage account module # 2378#2514
karthikvenkat17 merged 27 commits intoAzure:mainfrom
karthikvenkat17:kavenka-sftp-feature

Conversation

@karthikvenkat17
Copy link
Copy Markdown
Contributor

@karthikvenkat17 karthikvenkat17 commented Dec 28, 2022 •
edited
Loading

Description

Updated the storage account resource module to enable SFTP and NFSv3 for blob storage
Added localUsers sub module to deploy SFTP users

Pipeline references

Storage: StorageAccounts

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@karthikvenkat17 karthikvenkat17 changed the title Add SFTP feature to storage account module [Modules] Storage Accounts : Add SFTP feature to storage account module # 2378 Dec 28, 2022
@karthikvenkat17 karthikvenkat17 marked this pull request as ready for review December 28, 2022 16:18
@karthikvenkat17 karthikvenkat17 requested a review from a team as a code owner December 28, 2022 16:18
ahmadabdalla
ahmadabdalla requested changes Dec 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @karthikvenkat17 . Please see comments.

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Dec 28, 2022
ahmadabdalla
ahmadabdalla reviewed Dec 29, 2022
View reviewed changes
ahmadabdalla
ahmadabdalla approved these changes Dec 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@karthikvenkat17 karthikvenkat17 merged commit 3bb33df into Azure:main Dec 30, 2022
@zydio zydio mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@karthikvenkat17 karthikvenkat17

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikvenkat17 @ahmadabdalla