Skip to content

[Fixes] Replace 'adp' naming prefix across modules #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriqua merged 2 commits into from
Feb 8, 2023
Merged

[Fixes] Replace 'adp' naming prefix across modules #2665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c57934
remove adp ref
eriqua Feb 7, 2023
0c436e4
Merge branch 'main' into users/erikag/adp-cleanup
eriqua Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/Microsoft.Network/bastionHosts/.test/custompip/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ module testDeployment '../../deploy.bicep' = {
diagnosticMetricsToEnable: [
'AllMetrics'
]
name: 'adp-<<namePrefix>>-az-pip-custom-x-bas'
name: '<<namePrefix>>${serviceShort}001-pip'
publicIPAllocationMethod: 'Static'
publicIPPrefixResourceId: ''
roleAssignments: [
Expand Down
4 changes: 2 additions & 2 deletions modules/Microsoft.Network/bastionHosts/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ module bastionHosts './Microsoft.Network/bastionHosts/deploy.bicep' = {
diagnosticMetricsToEnable: [
'AllMetrics'
]
name: 'adp-<<namePrefix>>-az-pip-custom-x-bas'
name: '<<namePrefix>>nbhctmpip001-pip'
publicIPAllocationMethod: 'Static'
publicIPPrefixResourceId: ''
roleAssignments: [
Expand Down Expand Up @@ -499,7 +499,7 @@ module bastionHosts './Microsoft.Network/bastionHosts/deploy.bicep' = {
"diagnosticMetricsToEnable": [
"AllMetrics"
],
"name": "adp-<<namePrefix>>-az-pip-custom-x-bas",
"name": "<<namePrefix>>nbhctmpip001-pip",
"publicIPAllocationMethod": "Static",
"publicIPPrefixResourceId": "",
"roleAssignments": [
Expand Down
2 changes: 1 addition & 1 deletion modules/Microsoft.Sql/servers/.test/pe/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module nestedDependencies 'dependencies.bicep' = {
scope: resourceGroup
name: '${uniqueString(deployment().name, location)}-nestedDependencies'
params: {
virtualNetworkName: 'adp-<<namePrefix>>-vnet-${serviceShort}'
virtualNetworkName: 'dep-<<namePrefix>>-vnet-${serviceShort}'
location: location
}
}
Expand Down