Skip to content

[Modules] Compute gallery image definition update #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmadabdalla merged 4 commits into from
Feb 9, 2023
Merged

[Modules] Compute gallery image definition update #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46a4835
updated to include new features
Feb 9, 2023
77bca13
added tests
Feb 9, 2023
dcf44ea
fixed parameter name
Feb 9, 2023
635979a
updated description on accelerated networking
Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions modules/Microsoft.Compute/galleries/.test/common/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,52 @@ module testDeployment '../../deploy.bicep' = {
]
sku: '2022-datacenter-azure-edition'
}
{
hyperVGeneration: 'V2'
isHibernateSupported: 'true'
maxRecommendedMemory: 16
maxRecommendedvCPUs: 8
minRecommendedMemory: 4
minRecommendedvCPUs: 2
name: '<<namePrefix>>-az-imgd-ws-003'
offer: 'WindowsServer'
osState: 'Generalized'
osType: 'Windows'
publisher: 'MicrosoftWindowsServer'
roleAssignments: [
{
roleDefinitionIdOrName: 'Reader'
principalIds: [
nestedDependencies.outputs.managedIdentityPrincipalId
]
principalType: 'ServicePrincipal'
}
]
sku: '2022-datacenter-azure-edition-hibernate'
}
{
hyperVGeneration: 'V2'
isAcceleratedNetworkSupported: 'true'
maxRecommendedMemory: 16
maxRecommendedvCPUs: 8
minRecommendedMemory: 4
minRecommendedvCPUs: 2
name: '<<namePrefix>>-az-imgd-ws-004'
offer: 'WindowsServer'
osState: 'Generalized'
osType: 'Windows'
publisher: 'MicrosoftWindowsServer'
roleAssignments: [
{
roleDefinitionIdOrName: 'Reader'
principalIds: [
nestedDependencies.outputs.managedIdentityPrincipalId
]
principalType: 'ServicePrincipal'
}
]
sku: '2022-datacenter-azure-edition-accnet'
}
{
hyperVGeneration: 'V2'
securityType: 'TrustedLaunch'
Expand Down
37 changes: 36 additions & 1 deletion modules/Microsoft.Compute/galleries/images/deploy.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,24 @@ param hyperVGeneration string = ''
])
param securityType string = 'Standard'

@description('Optional. The image will support hibernation.')
@allowed([
'true'
'false'
])
param isHibernateSupported string = 'false'

@description('''Optional. The image supports accelerated networking.
Accelerated networking enables single root I/O virtualization (SR-IOV) to a VM, greatly improving its networking performance.
This high-performance path bypasses the host from the data path, which reduces latency, jitter, and CPU utilization for the
most demanding network workloads on supported VM types.
''')
@allowed([
'true'
'false'
])
param isAcceleratedNetworkSupported string = 'false'

@description('Optional. The description of this gallery Image Definition resource. This property is updatable.')
param imageDefinitionDescription string = ''

Expand Down Expand Up @@ -152,7 +170,24 @@ resource image 'Microsoft.Compute/galleries/images@2022-03-03' = {
name: 'SecurityType'
value: securityType
}
] : null
{
name: 'IsAcceleratedNetworkSupported'
value: isAcceleratedNetworkSupported
}
{
name: 'IsHibernateSupported'
value: isHibernateSupported
}
] : [
{
name: 'IsAcceleratedNetworkSupported'
value: isAcceleratedNetworkSupported
}
{
name: 'IsHibernateSupported'
value: isHibernateSupported
}
]
description: imageDefinitionDescription
eula: eula
privacyStatementUri: privacyStatementUri
Expand Down
2 changes: 2 additions & 0 deletions modules/Microsoft.Compute/galleries/images/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ This module deploys an Image Definition in a Shared Image Gallery.
| `excludedDiskTypes` | array | `[]` | | List of the excluded disk types. E.g. Standard_LRS. |
| `hyperVGeneration` | string | `''` | `['', V1, V2]` | The hypervisor generation of the Virtual Machine.<p>* If this value is not specified, then it is determined by the securityType parameter.<p>* If the securityType parameter is specified, then the value of hyperVGeneration will be V2, else V1.<p> |
| `imageDefinitionDescription` | string | `''` | | The description of this gallery Image Definition resource. This property is updatable. |
| `isAcceleratedNetworkSupported` | string | `'false'` | `[false, true]` | The image supports accelerated networking.<p>Accelerated networking enables single root I/O virtualization (SR-IOV) to a VM, greatly improving its networking performance.<p>This high-performance path bypasses the host from the data path, which reduces latency, jitter, and CPU utilization for the<p>most demanding network workloads on supported VM types.<p> |
| `isHibernateSupported` | string | `'false'` | `[false, true]` | The image will support hibernation. |
| `location` | string | `[resourceGroup().location]` | | Location for all resources. |
| `maxRecommendedMemory` | int | `16` | | The maximum amount of RAM in GB recommended for this image. |
| `maxRecommendedvCPUs` | int | `4` | | The maximum number of the CPU cores recommended for this image. |
Expand Down
92 changes: 92 additions & 0 deletions modules/Microsoft.Compute/galleries/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,52 @@ module galleries './Microsoft.Compute/galleries/deploy.bicep' = {
]
sku: '2022-datacenter-azure-edition'
}
{
hyperVGeneration: 'V2'
isHibernateSupported: 'true'
maxRecommendedMemory: 16
maxRecommendedvCPUs: 8
minRecommendedMemory: 4
minRecommendedvCPUs: 2
name: '<<namePrefix>>-az-imgd-ws-003'
offer: 'WindowsServer'
osState: 'Generalized'
osType: 'Windows'
publisher: 'MicrosoftWindowsServer'
roleAssignments: [
{
principalIds: [
'<managedIdentityPrincipalId>'
]
principalType: 'ServicePrincipal'
roleDefinitionIdOrName: 'Reader'
}
]
sku: '2022-datacenter-azure-edition-hibernate'
}
{
hyperVGeneration: 'V2'
isAcceleratedNetworkSupported: 'true'
maxRecommendedMemory: 16
maxRecommendedvCPUs: 8
minRecommendedMemory: 4
minRecommendedvCPUs: 2
name: '<<namePrefix>>-az-imgd-ws-004'
offer: 'WindowsServer'
osState: 'Generalized'
osType: 'Windows'
publisher: 'MicrosoftWindowsServer'
roleAssignments: [
{
principalIds: [
'<managedIdentityPrincipalId>'
]
principalType: 'ServicePrincipal'
roleDefinitionIdOrName: 'Reader'
}
]
sku: '2022-datacenter-azure-edition-accnet'
}
{
hyperVGeneration: 'V2'
maxRecommendedMemory: 16
Expand Down Expand Up @@ -338,6 +384,52 @@ module galleries './Microsoft.Compute/galleries/deploy.bicep' = {
],
"sku": "2022-datacenter-azure-edition"
},
{
"hyperVGeneration": "V2",
"isHibernateSupported": "true",
"maxRecommendedMemory": 16,
"maxRecommendedvCPUs": 8,
"minRecommendedMemory": 4,
"minRecommendedvCPUs": 2,
"name": "<<namePrefix>>-az-imgd-ws-003",
"offer": "WindowsServer",
"osState": "Generalized",
"osType": "Windows",
"publisher": "MicrosoftWindowsServer",
"roleAssignments": [
{
"principalIds": [
"<managedIdentityPrincipalId>"
],
"principalType": "ServicePrincipal",
"roleDefinitionIdOrName": "Reader"
}
],
"sku": "2022-datacenter-azure-edition-hibernate"
},
{
"hyperVGeneration": "V2",
"isAcceleratedNetworkSupported": "true",
"maxRecommendedMemory": 16,
"maxRecommendedvCPUs": 8,
"minRecommendedMemory": 4,
"minRecommendedvCPUs": 2,
"name": "<<namePrefix>>-az-imgd-ws-004",
"offer": "WindowsServer",
"osState": "Generalized",
"osType": "Windows",
"publisher": "MicrosoftWindowsServer",
"roleAssignments": [
{
"principalIds": [
"<managedIdentityPrincipalId>"
],
"principalType": "ServicePrincipal",
"roleDefinitionIdOrName": "Reader"
}
],
"sku": "2022-datacenter-azure-edition-accnet"
},
{
"hyperVGeneration": "V2",
"maxRecommendedMemory": 16,
Expand Down