Skip to content

[Modules] Extend managedClusters with flux config#2678

Closed
MariusStorhaug wants to merge 31 commits intomainfrom
users/mast/k8sExtensions
Closed

[Modules] Extend managedClusters with flux config#2678
MariusStorhaug wants to merge 31 commits intomainfrom
users/mast/k8sExtensions

Conversation

@MariusStorhaug
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug commented Feb 9, 2023 •
edited
Loading

Description

  • Adding ability to specify flux (GitOps) settings for a managedCluster, cross-referencing KubernetesServices/extensions and KubernetesServices/fluxExtensions.
  • Added tests for flux config
  • Updated readme.

Pipeline references

Pipeline
ContainerService: ManagedClusters

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 9, 2023 •
edited
Loading

Test Results

  1 files    1 suites   49s ⏱️
86 tests 85 ✔️ 1 💤 0 ❌
98 runs  94 ✔️ 4 💤 0 ❌

Results for commit 60d1e89.

♻️ This comment has been updated with latest results.

AlexanderSehr
AlexanderSehr reviewed Feb 9, 2023
View reviewed changes
@AlexanderSehr AlexanderSehr changed the title Extend managedClusters with flux config [Modules] Extend managedClusters with flux config Feb 9, 2023
@MariusStorhaug MariusStorhaug marked this pull request as ready for review February 9, 2023 19:32
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner February 9, 2023 19:32
@AlexanderSehr
Update modules/Microsoft.ContainerService/managedClusters/deploy.bicep
156ebb5 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@MariusStorhaug MariusStorhaug added the [cat] modules category: modules label Feb 10, 2023
@MariusStorhaug MariusStorhaug added this to the Release v0.10.0 milestone Feb 10, 2023
@MariusStorhaug MariusStorhaug linked an issue Feb 10, 2023 that may be closed by this pull request
[Feature Request]: Add flux support to AKS (managedClusters) #2656
Closed
@MariusStorhaug MariusStorhaug added the enhancement New feature or request label Feb 10, 2023
@AlexanderSehr AlexanderSehr deleted the users/mast/k8sExtensions branch May 13, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua eriqua left review comments

Assignees

@MariusStorhaug MariusStorhaug

Labels

[cat] modules category: modules enhancement New feature or request

Projects

Backlog
Status: In progress

Milestone

Release v0.10.0

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add flux support to AKS (managedClusters)

3 participants

@MariusStorhaug @AlexanderSehr @eriqua