Skip to content

[Modules] DocumentDB - Add enable free tier tag to cosmos db properties#3128

Merged
ahmadabdalla merged 5 commits intoAzure:mainfrom
samuelya:users/samg/enableFreeTierForCosmosDb
Apr 25, 2023
Merged

[Modules] DocumentDB - Add enable free tier tag to cosmos db properties#3128
ahmadabdalla merged 5 commits intoAzure:mainfrom
samuelya:users/samg/enableFreeTierForCosmosDb

Conversation

@samuelya
Copy link
Copy Markdown
Contributor

@samuelya samuelya commented Apr 20, 2023

Description

Added enablefreetier to properties of cosmos db to allow the deployment of cosmos db using free tier which will be useful for the development environment

Fixes: #3125

List any dependencies that are required for this change.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DocumentDB - DatabaseAccounts

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@samuelya samuelya marked this pull request as ready for review April 20, 2023 07:22
@samuelya samuelya requested a review from a team as a code owner April 20, 2023 07:22
@samuelya
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@samuelya samuelya changed the title Add enable free tier tag to cosmos db properties [Module] DocumentDB - Add enable free tier tag to cosmos db properties Apr 20, 2023
@samuelya samuelya changed the title [Module] DocumentDB - Add enable free tier tag to cosmos db properties [Modules] DocumentDB - Add enable free tier tag to cosmos db properties Apr 20, 2023
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Apr 20, 2023
@ahmadabdalla
Copy link
Copy Markdown
Contributor

@samuelya thanks for your contribution. Can you please attach a successful pipeline/workflow run for the change? Happy to support you if you need assistance in that.

@samuelya
Copy link
Copy Markdown
Contributor Author

samuelya commented Apr 23, 2023

@samuelya thanks for your contribution. Can you please attach a successful pipeline/workflow run for the change? Happy to support you if you need assistance in that.

Hi @ahmadabdalla I have enabled the actions from my forked repository and have attached the successful workflow from it. Is that what you were expecting? Thanks

@samuelya samuelya changed the title [Modules] DocumentDB - Add enable free tier tag to cosmos db properties [Modules] DocumentDB - Add enable free tier tag to cosmos db properties #3125 Apr 24, 2023
@samuelya samuelya changed the title [Modules] DocumentDB - Add enable free tier tag to cosmos db properties #3125 [Modules] DocumentDB - Add enable free tier tag to cosmos db properties Apr 24, 2023
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samuelya :) And thanks for attaching the pipeline run. I've added a suggestion, can you please review. Also would require regenerating the documentation. Thanks

@samuelya samuelya requested a review from ahmadabdalla April 24, 2023 09:11
@ahmadabdalla ahmadabdalla merged commit 19f72bc into Azure:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add enableFreeTier flag to cosmos db account

3 participants