Skip to content

[Modules] Correct max length of Application Gateway name#3199

Merged
eriqua merged 1 commit intoAzure:mainfrom
SvenAelterman:patch-1
May 11, 2023
Merged

[Modules] Correct max length of Application Gateway name#3199
eriqua merged 1 commit intoAzure:mainfrom
SvenAelterman:patch-1

Conversation

@SvenAelterman
Copy link
Copy Markdown
Contributor

@SvenAelterman SvenAelterman commented May 11, 2023 •
edited
Loading

Description

Per https://learn.microsoft.com/azure/azure-resource-manager/management/resource-name-rules#microsoftnetwork, it's 80 characters.

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@SvenAelterman SvenAelterman requested a review from a team as a code owner May 11, 2023 21:28
@eriqua eriqua changed the title Correct max length of Application Gateway name [Modules] Correct max length of Application Gateway name May 11, 2023
@eriqua eriqua enabled auto-merge (squash) May 11, 2023 23:05
@eriqua eriqua added bug Something isn't working [cat] modules category: modules labels May 11, 2023
@SvenAelterman
Copy link
Copy Markdown
Contributor Author

SvenAelterman commented May 11, 2023

@eriqua Sorry, why was this assigned to me?

@eriqua
Copy link
Copy Markdown
Contributor

eriqua commented May 11, 2023

@eriqua Sorry, why was this assigned to me?

Hey @SvenAelterman, we use to assign PR authors :)

eriqua
eriqua approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua merged commit ff5e257 into Azure:main May 11, 2023
@AlexanderSehr AlexanderSehr mentioned this pull request May 29, 2023
Closed
@AlexanderSehr AlexanderSehr linked an issue May 29, 2023 that may be closed by this pull request
Application Gateway name length restriction #2894
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@SvenAelterman SvenAelterman

Labels

bug Something isn't working [cat] modules category: modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Application Gateway name length restriction

2 participants

@SvenAelterman @eriqua