[Modules] storage account module : conditional nfsv3 parameter #3290
Merged
ahmadabdalla merged 1 commit intoAzure:mainfrom Jun 4, 2023
Merged
[Modules] storage account module : conditional nfsv3 parameter #3290ahmadabdalla merged 1 commit intoAzure:mainfrom
ahmadabdalla merged 1 commit intoAzure:mainfrom
Conversation
7 tasks
Contributor
Author
|
this PR will replace: |
Contributor
|
@Robbertbbb thanks for your contribution and the new PR. Can you please attach a successful pipeline run for this change? |
Contributor
Author
|
Hi,I don’t have the resources todo a pipeline run for it. Op 3 jun. 2023 om 05:20 heeft Ahmad Abdalla ***@***.***> het volgende geschreven:
@Robbertbbb thanks for your contribution and the new PR. Can you please attach a successful pipeline run for this change?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
|
@Robbertbbb I have tested the changes. Will be approving this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will fix #3106
only send the nfsv3 when enabled
cannot be changed or added with a value of False if the storage account wasn't creating with it.
this is fixing an breaking change
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist