Skip to content

[Modules] ML - Wait on Private Endpoints before creating compute instances #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderSehr merged 13 commits into from
Sep 4, 2023
Merged

[Modules] ML - Wait on Private Endpoints before creating compute instances #3715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a359f27
wait on PeP before creating compute
Sdelausnay Aug 23, 2023
0830fb6
fix private end-point
Sdelausnay Aug 23, 2023
a7ebcd5
reset pep
Sdelausnay Aug 23, 2023
832a687
change pep
Sdelausnay Aug 23, 2023
5204cd1
update version
Sdelausnay Aug 23, 2023
5501d05
update readme
Sdelausnay Aug 23, 2023
a1059cf
fix json
Sdelausnay Aug 23, 2023
24576ad
fix json
Sdelausnay Aug 23, 2023
26e202d
update mls json
Sdelausnay Aug 23, 2023
1bd8a5a
update documents
Sdelausnay Aug 23, 2023
6fde0f4
reset settings
Sdelausnay Aug 24, 2023
74de886
Merge branch 'Azure:main' into user/sdelausnay/fixDependsMls
Sdelausnay Aug 28, 2023
fa9048a
Merge branch 'main' into user/sdelausnay/fixDependsMls
AlexanderSehr Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/machine-learning-services/workspace/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,9 @@ module workspace_computes 'compute/main.bicep' = [for compute in computes: {
computeType: compute.computeType
properties: contains(compute, 'properties') ? compute.properties : {}
}
dependsOn: [
workspace_privateEndpoints
]
}]

resource workspace_lock 'Microsoft.Authorization/locks@2020-05-01' = if (!empty(lock)) {
Expand Down
9 changes: 5 additions & 4 deletions modules/machine-learning-services/workspace/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.20.4.51522",
"templateHash": "12489776525535905441"
"templateHash": "9807343240175832898"
},
"name": "Machine Learning Services Workspaces",
"description": "This module deploys a Machine Learning Services Workspace.",
Expand Down Expand Up @@ -634,7 +634,8 @@
}
},
"dependsOn": [
"[resourceId('Microsoft.MachineLearningServices/workspaces', parameters('name'))]"
"[resourceId('Microsoft.MachineLearningServices/workspaces', parameters('name'))]",
"workspace_privateEndpoints"
]
},
{
Expand Down Expand Up @@ -683,7 +684,7 @@
"_generator": {
"name": "bicep",
"version": "0.20.4.51522",
"templateHash": "13560297539192628062"
"templateHash": "16616509457944914829"
},
"name": "Private Endpoints",
"description": "This module deploys a Private Endpoint.",
Expand Down Expand Up @@ -883,7 +884,7 @@
"_generator": {
"name": "bicep",
"version": "0.20.4.51522",
"templateHash": "17831763001460207830"
"templateHash": "18114841529204248478"
},
"name": "Private Endpoint Private DNS Zone Groups",
"description": "This module deploys a Private Endpoint Private DNS Zone Group.",
Expand Down