Skip to content

Users/sogangul/bicep service fabric clusters#537

Merged
AlexanderSehr merged 79 commits intoAzure:mainfrom
SomilGanguly:users/sogangul/bicep_serviceFabricClusters
Jan 26, 2022
Merged

Users/sogangul/bicep service fabric clusters#537
AlexanderSehr merged 79 commits intoAzure:mainfrom
SomilGanguly:users/sogangul/bicep_serviceFabricClusters

Conversation

@SomilGanguly
Copy link
Copy Markdown
Contributor

@SomilGanguly SomilGanguly commented Nov 24, 2021

Change

Feel free to remove this sample text

Thank you for your contribution !
This PR includes the service fabric module.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Kavish Shivhare and others added 30 commits October 14, 2021 20:35
Add base bicep script for service fabric cluster and add nested cua b…
d6d0327 
…icep file.
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
07c8b61 
…into users/sogangul/bicep_serviceFabricClusters
Update bicep file and add param file.
54f758e
Update biceps and parameters file.
3919fdb
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
f697d12 
…into users/sogangul/bicep_serviceFabricClusters
Remove duplicate output section.
8c00c5e
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
0353c38 
…into users/sogangul/bicep_serviceFabricClusters
Update deploy.bicep and params file and add the nested rbac file.
e969e09
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
eb3edfb 
…into users/sogangul/bicep_serviceFabricClusters
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
4c05558 
…into users/sogangul/bicep_serviceFabricClusters
Update bicep and param files.
177fee8
Remove unwanted files.
bac6121
Update deploy and param file and add nested applicationServices and a…
d89c07b 
…pplicationTypesVersions bicep files.
Add workflow and update README.md.
ef81308
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
d301ebc 
…into users/sogangul/bicep_serviceFabricClusters
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
5935f82 
…into users/sogangul/bicep_serviceFabricClusters
Process review comments.
935f4a3
@kavishshivhare
Merge branch 'Azure:main' into users/sogangul/bicep_serviceFabricClus…
655a706 
…ters
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
8569e7c 
…into users/sogangul/bicep_serviceFabricClusters
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
90444de 
…into users/sogangul/bicep_serviceFabricClusters
Update Service fabric bicep module with updated child modules.
5134441
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
1a7f7bb 
…into users/sogangul/bicep_serviceFabricClusters
Update managementEndpoint param in line with cluster name.
a6e0682
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
7776b73 
…into users/sogangul/bicep_serviceFabricClusters
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
6ef532f 
…into users/sogangul/bicep_serviceFabricClusters
Update to latest codebase from the source org's backup branch.
1acfcc9
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
43be846 
…into users/sogangul/bicep_serviceFabricClusters
Create nested module for service fabric prereqs and update deploy.bicep.
dd41e61
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
a251242 
…into users/sogangul/bicep_serviceFabricClusters
Merge branch 'main' of https://github.com/SomilGanguly/ResourceModules …
6990443 
…into users/sogangul/bicep_serviceFabricClusters
AlexanderSehr and others added 26 commits January 10, 2022 14:12
@AlexanderSehr
Update to latest
b2f4618
@AlexanderSehr
Removed any trace of resource we currently cannot test
a2ea050
@AlexanderSehr
Enabled upgrade desc
ea0ed90
@AlexanderSehr
Enabled upgrade desc
e9ea1f0
@AlexanderSehr
Update to latest
67384eb
@AlexanderSehr
Update to latest
fd4b92e
@AlexanderSehr
Update to latest
98e0c37
@AlexanderSehr
Added AAD
66c409e
@AlexanderSehr
Added min file
3182539
@AlexanderSehr
Update to latest
77e9528
@AlexanderSehr
Update to latest
ec66706
@AlexanderSehr
Update to latest
c833ef4
@AlexanderSehr
Update to latest
eeef425
@AlexanderSehr
Updated param
754aa5b
@AlexanderSehr
Updated docs
df8e04e
@AlexanderSehr
Merge branch 'main' into users/alsehr/sfTest
007a6cb
@AlexanderSehr
Minor update
9ce1199
@AlexanderSehr
Merge branch 'main' into users/sogangul/bicep_serviceFabricClusters
b8dd3a4
@AlexanderSehr
Merge branch 'users/sogangul/bicep_serviceFabricClusters' into users/…
789e9df 
…alsehr/sfTest
@AlexanderSehr
Fixed endpoints
d0f8317
@AlexanderSehr
Fixed tags
e25513f
@AlexanderSehr
Removed dots
debe4a9
@SomilGanguly
Merge pull request #2 from SomilGanguly/users/alsehr/sfTest
de13d29 
Refactored & reduced PR
@AlexanderSehr
Updated to latest naming
631b5f3
@AlexanderSehr
Updated GH workflow to latest & added ADO pipeline
751ee1a
@AlexanderSehr
Minor update
9927ed6
Msanzdelrio
Msanzdelrio reviewed Jan 25, 2022
View reviewed changes
@AlexanderSehr AlexanderSehr merged commit 0e84ec8 into Azure:main Jan 26, 2022
@AlexanderSehr AlexanderSehr deleted the users/sogangul/bicep_serviceFabricClusters branch January 26, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@kavishshivhare kavishshivhare kavishshivhare left review comments

@Msanzdelrio Msanzdelrio Msanzdelrio approved these changes

Assignees

@SomilGanguly SomilGanguly

Labels

[cat] modules category: modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ServiceFabric: Fix and add the missing serviceFabric module

4 participants

@SomilGanguly @AlexanderSehr @Msanzdelrio @kavishshivhare