Skip to content

Updated kind & added param file#701

Merged
AlexanderSehr merged 2 commits intomainfrom
users/alsehr/184_deplScript_kind
Dec 2, 2021
Merged

Updated kind & added param file#701
AlexanderSehr merged 2 commits intomainfrom
users/alsehr/184_deplScript_kind

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

Change

  • Updated kind param reference
  • Added param file for CLI

Pipeline reference
Resources: DeploymentScripts

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Dec 1, 2021
@AlexanderSehr AlexanderSehr added [cat] modules category: modules enhancement New feature or request labels Dec 1, 2021
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Dec 1, 2021
@AlexanderSehr AlexanderSehr linked an issue Dec 1, 2021 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2021

Unit Test Results

  1 files  ±  0  1 suites  ±0   15s ⏱️ -4s
  2 tests  - 30  2 ✔️  - 30    0 💤 ±  0  0 ±0 
35 runs   -   6  2 ✔️  - 31  33 💤 +25  0 ±0 

Results for commit 472a9e1. ± Comparison against base commit f86fdfb.

This pull request removes 32 and adds 2 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.OperationalInsights/workspaces] Template schema should use HTTPS reference
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Resources/deploymentScripts] used resource type [deploymentScripts] should use on of the recent API version(s). Currently using [2020-10-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Resources/deploymentScripts] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 1, 2021 13:19
@AlexanderSehr AlexanderSehr merged commit 7083d72 into main Dec 2, 2021
@MariusStorhaug MariusStorhaug deleted the users/alsehr/184_deplScript_kind branch December 2, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kind property in Deployment Script modules is hardcoded

2 participants