Skip to content

Target NSGs in seperate resource group #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderSehr merged 4 commits into from
Dec 6, 2021
Merged

Target NSGs in seperate resource group #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0f3d3f
Target NSGs in seperate resource group
jceval Dec 3, 2021
76f440d
Notes
jceval Dec 3, 2021
2a8ded0
change type
jceval Dec 3, 2021
6dba842
Update readme.md
jceval Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion arm/Microsoft.Network/virtualNetworks/deploy.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ param addressPrefixes array
@minLength(1)
param subnets array

@description('Optional. Resource Group where NSGs are deployed, if different than VNET Resource Group.')
@minLength(1)
param nsgResourceGroup string = resourceGroup().name

@description('Optional. DNS Servers associated to the Virtual Network.')
param dnsServers array = []

Expand Down Expand Up @@ -116,7 +120,7 @@ resource virtualNetwork 'Microsoft.Network/virtualNetworks@2021-05-01' = {
name: item.name
properties: {
addressPrefix: item.addressPrefix
networkSecurityGroup: contains(item, 'networkSecurityGroupName') ? (empty(item.networkSecurityGroupName) ? null : json('{"id": "${resourceId('Microsoft.Network/networkSecurityGroups', item.networkSecurityGroupName)}"}')) : null
networkSecurityGroup: contains(item, 'networkSecurityGroupName') ? (empty(item.networkSecurityGroupName) ? null : json('{"id": "${resourceId(nsgResourceGroup, 'Microsoft.Network/networkSecurityGroups', item.networkSecurityGroupName)}"}')) : null
routeTable: contains(item, 'routeTableName') ? (empty(item.routeTableName) ? null : json('{"id": "${resourceId('Microsoft.Network/routeTables', item.routeTableName)}"}')) : null
serviceEndpoints: contains(item, 'serviceEndpoints') ? (empty(item.serviceEndpoints) ? null : item.serviceEndpoints) : null
delegations: contains(item, 'delegations') ? (empty(item.delegations) ? null : item.delegations) : null
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Network/virtualNetworks/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ This template deploys a virtual network (vNet).
| `name` | string | | | Required. The Virtual Network (vNet) Name. |
| `roleAssignments` | array | `[]` | | Optional. Array of role assignment objects that contain the 'roleDefinitionIdOrName' and 'principalId' to define RBAC role assignments on this resource. In the roleDefinitionIdOrName attribute, you can provide either the display name of the role definition, or its fully qualified ID in the following format: '/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11' |
| `subnets` | array | | | Required. An Array of subnets to deploy to the Virual Network. |
| `nsgResourceGroup` | string | `[resourceGroup().name]` | | Optional. Resource Group where NSGs are deployed, if different than VNET Resource Group. |
| `tags` | object | `{object}` | | Optional. Tags of the resource. |
| `virtualNetworkPeerings` | _[virtualNetworkPeerings](virtualNetworkPeerings/readme.md)_ array | `[]` | | Optional. Virtual Network Peerings configurations |
| `workspaceId` | string | | | Optional. Resource ID of log analytics. |
Expand Down