Azure · ahmadabdalla · Dec 6, 2021 · Dec 5, 2021 · Dec 6, 2021 · Dec 6, 2021
diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -27,3 +27,16 @@ jobs:
           DEFAULT_BRANCH: ${{ github.base_ref }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           FILTER_REGEX_EXCLUDE: '[global.module.tests.ps1|Get\-ModulesAsMarkdownTable.ps1]'
+
+      - name: Link Checker
+        if: always()
+        id: checker
+        uses: lycheeverse/lychee-action@v1.1.1
+        with:
+          args: --verbose --no-progress **/*.md --exclude-file .lycheeignore --accept 200,201,403,429
+        env:
+          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+
+      - name: Link Checker Results
+        if: always()
+        run: exit ${{ steps.checker.outputs.exit_code }}
diff --git a/.lycheeignore b/.lycheeignore
@@ -0,0 +1,8 @@
+https://foo.psd1/
+file:///github
+https://mystorageaccount.blob.core.windows.net
+https://mykeyvault.vault.azure.net
+https://www.powershellgallery.com
+https://github.com/myProject
+http://validURLToConfigLocation/
+https://myCustomDependencyLocation/
diff --git a/arm/Microsoft.Compute/virtualMachineScaleSets/readme.md b/arm/Microsoft.Compute/virtualMachineScaleSets/readme.md
@@ -197,25 +197,16 @@ The following resources are required to be able to deploy this resource.
 
 
 ```json
-"extensionDomainJoinConfig": {
-    "value": {
-        "settings": {
-            "Name": "<domain>.onmicrosoft.com",
-            "User": "domainJoinUser02@<domain>.onmicrosoft.com",
-            "OUPath": "OU=Template-Test; DC=<domain>; DC=onmicrosoft; DC=com",
-            "Restart": true,
-            "Options": ""
-        }
-    }
-}
-```
-
-Should be configured alongside:
-```json
-"extensionDomainJoinPassword": {
-    "reference": {
-        "keyVault": {
-            "id": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.KeyVault/vaults/<keyVault>"
+"windowsScriptExtensionFileData": {
+    "value": [
+        //storage accounts with SAS token requirement
+        {
+            "uri": "https://mystorageAccount.blob.core.windows.net/avdscripts/File1.ps1",
+            "storageAccountId": "/subscriptions/12345678-1234-1234-1234-123456789012/resourceGroups/rgName/providers/Microsoft.Storage/storageAccounts/storageAccountName"
+        },
+        {
+            "uri": "https://mystorageAccount.blob.core.windows.net/avdscripts/File2.ps1",
+            "storageAccountId": "/subscriptions/12345678-1234-1234-1234-123456789012/resourceGroups/rgName/providers/Microsoft.Storage/storageAccounts/storageAccountName"
         },
         "secretName": "domainJoinUser-Password"
     }

diff --git a/arm/Microsoft.Compute/virtualMachines/readme.md b/arm/Microsoft.Compute/virtualMachines/readme.md
@@ -343,9 +343,9 @@ Only for OSType Windows
 "diskEncryptionSettings": {
   "value": {
       "EncryptionOperation": "EnableEncryption",
-      "KeyVaultURL": "https://adp-sxx-az-kv-x-001.vault.azure.net/",
+      "KeyVaultURL": "https://mykeyvault.vault.azure.net/",
       "KeyVaultResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.KeyVault/vaults/adp-sxx-az-kv-x-001",
-      "KeyEncryptionKeyURL": "https://adp-sxx-az-kv-x-001.vault.azure.net/keys/keyEncryptionKey/685153483a1140e3856f004a753e1ab4",
+      "KeyEncryptionKeyURL": "https://mykeyvault.vault.azure.net/keys/keyEncryptionKey/685153483a1140e3856f004a753e1ab4",
       "KekVaultResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.KeyVault/vaults/adp-sxx-az-kv-x-001",
       "KeyEncryptionAlgorithm": "RSA-OAEP", //'RSA-OAEP'/'RSA-OAEP-256'/'RSA1_5'
       "VolumeType": "All", //'OS'/'Data'/'All'
@@ -409,11 +409,11 @@ Only for OSType Windows
   "value": [
     //storage accounts with SAS token requirement
     {
-      "uri": "https://storageAccount.blob.core.windows.net/avdscripts/File1.ps1",
+      "uri": "https://mystorageaccount.blob.core.windows.net/avdscripts/File1.ps1",
       "storageAccountId": "/subscriptions/12345678-1234-1234-1234-123456789012/resourceGroups/rgName/providers/Microsoft.Storage/storageAccounts/storageAccountName"
     },
     {
-      "uri": "https://storageAccount.blob.core.windows.net/avdscripts/File2.ps1",
+      "uri": "https://mystorageaccount.blob.core.windows.net/avdscripts/File2.ps1",
       "storageAccountId": "/subscriptions/12345678-1234-1234-1234-123456789012/resourceGroups/rgName/providers/Microsoft.Storage/storageAccounts/storageAccountName"
     },
     //storage account with public container (no SAS token is required) OR other public URL (not a storage account)

diff --git a/arm/Microsoft.ContainerService/managedClusters/agentPools/readme.md b/arm/Microsoft.ContainerService/managedClusters/agentPools/readme.md
@@ -48,7 +48,7 @@ For available properties check <https://docs.microsoft.com/en-us/azure/templates
             "mode": "System",
             "vnetSubnetID": "/subscriptions/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/resourceGroups/myRg/providers/Microsoft.Network/virtualNetworks/myVnet/subnets/mySubnet",
             "tags": {
-                "Owner": "abc.def@contoso.com",
+                "Owner": "test.user@testcompany.com",
                 "BusinessUnit": "IaCs",
                 "Environment": "PROD",
                 "Region": "USEast"

diff --git a/arm/Microsoft.ContainerService/managedClusters/readme.md b/arm/Microsoft.ContainerService/managedClusters/readme.md
@@ -171,7 +171,7 @@ For available properties check <https://docs.microsoft.com/en-us/azure/templates
       "mode": "System",
       "vnetSubnetID": "/subscriptions/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/resourceGroups/myRg/providers/Microsoft.Network/virtualNetworks/myVnet/subnets/mySubnet",
       "tags": {
-        "Owner": "abc.def@contoso.com",
+        "Owner": "test.user@testcompany.com",
         "BusinessUnit": "IaCs",
         "Environment": "PROD",
         "Region": "USEast"
@@ -215,7 +215,7 @@ For available properties check <https://docs.microsoft.com/en-us/azure/templates
                 "mode": "System",
                 "vnetSubnetID": "/subscriptions/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/resourceGroups/myRg/providers/Microsoft.Network/virtualNetworks/myVnet/subnets/mySubnet",
                 "tags": {
-                    "Owner": "abc.def@contoso.com",
+                    "Owner": "test.user@testcompany.com",
                     "BusinessUnit": "IaCs",
                     "Environment": "PROD",
                     "Region": "USEast"

diff --git a/arm/Microsoft.Sql/servers/securityAlertPolicies/deploy.bicep b/arm/Microsoft.Sql/servers/securityAlertPolicies/deploy.bicep
@@ -24,7 +24,7 @@ param state string = 'Disabled'
 @secure()
 param storageAccountAccessKey string = ''
 
-@description('Optional. Specifies the blob storage endpoint (e.g. https://MyAccount.blob.core.windows.net). This blob storage will hold all Threat Detection audit logs.')
+@description('Optional. Specifies the blob storage endpoint (e.g. https://mystorageaccount.blob.core.windows.net). This blob storage will hold all Threat Detection audit logs.')
 param storageEndpoint string = ''
 
 @description('Required. The Name of SQL Server')

diff --git a/arm/Microsoft.Sql/servers/securityAlertPolicies/readme.md b/arm/Microsoft.Sql/servers/securityAlertPolicies/readme.md
@@ -21,7 +21,7 @@ This module deploys an SQL Server Security Alert Policy.
 | `serverName` | string |  |  | Required. The Name of SQL Server |
 | `state` | string | `Disabled` | `[Disabled, Enabled]` | Optional. Specifies the state of the policy, whether it is enabled or disabled or a policy has not been applied yet on the specific database. |
 | `storageAccountAccessKey` | secureString |  |  | Optional. Specifies the identifier key of the Threat Detection audit storage account.. |
-| `storageEndpoint` | string |  |  | Optional. Specifies the blob storage endpoint (e.g. https://MyAccount.blob.core.windows.net). This blob storage will hold all Threat Detection audit logs. |
+| `storageEndpoint` | string |  |  | Optional. Specifies the blob storage endpoint (e.g. https://mystorageaccount.blob.core.windows.net). This blob storage will hold all Threat Detection audit logs. |
 
 ## Outputs
 

diff --git a/docs/wiki/ModulesUsage.md b/docs/wiki/ModulesUsage.md
@@ -70,7 +70,7 @@ New-AzResourceGroup -Name 'ExampleGroup' -Location "Central US"
 $inputObject = @{
  DeploymentName    = 'ExampleDeployment'
  ResourceGroupName = 'ExampleGroup'
- TemplateUri       = 'https://raw.githubusercontent.com/arm/ResourceModules/main/arm/Microsoft.KeyVault/vaults/deploy.json'
+ TemplateUri       = 'https://raw.githubusercontent.com/Azure/ResourceModules/main/arm/Microsoft.KeyVault/vaults/deploy.bicep'
 }
 New-AzResourceGroupDeployment @inputObject
 ```
@@ -83,7 +83,7 @@ az group create --name 'ExampleGroup' --location "Central US"
 $inputObject = @(
     '--name',           'ExampleDeployment',
     '--resource-group', 'ExampleGroup',
-    '--template-uri',   'https://raw.githubusercontent.com/arm/ResourceModules/main/arm/Microsoft.KeyVault/vaults/deploy.json',
+    '--template-uri',   'https://raw.githubusercontent.com/Azure/ResourceModules/main/arm/Microsoft.KeyVault/vaults/deploy.bicep',
     '--parameters',     'storageAccountType=Standard_GRS',
 )
 az deployment group create @inputObject

diff --git a/docs/wiki/TestingDesign.md b/docs/wiki/TestingDesign.md
@@ -63,7 +63,7 @@ The following activities are run executing the `arm/.global/global.module.tests.
 
 - [Pester Wiki](https://github.com/pester/Pester/wiki)
 - [Pester on GitHub](https://github.com/pester/Pester)
-- [Pester Setup and Commands](https://pester.dev/docs/commands/Setup)
+- [Pester Installation and Update](https://pester.dev/docs/introduction/installation)
 
 ---