Skip to content

Added backup config to rsv module#755

Merged
AlexanderSehr merged 3 commits intomainfrom
users/alsehr/backupconfig
Dec 6, 2021
Merged

Added backup config to rsv module#755
AlexanderSehr merged 3 commits intomainfrom
users/alsehr/backupconfig

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Dec 6, 2021

Change

  • Added backup config to rsv module
  • Updated param file
  • Updated documentation

Pipeline reference
RecoveryServices: Vaults

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Dec 6, 2021
@AlexanderSehr AlexanderSehr marked this pull request as draft December 6, 2021 19:19
@AlexanderSehr AlexanderSehr added [cat] modules category: modules enhancement New feature or request labels Dec 6, 2021
@AlexanderSehr AlexanderSehr linked an issue Dec 6, 2021 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2021

Unit Test Results

  1 files  ±0    1 suites  ±0   18s ⏱️ +4s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ±0 
41 runs  +7  33 ✔️ +1  8 💤 +6  0 ±0 

Results for commit 286fac3. ± Comparison against base commit 2a6a870.

This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/activityLogAlerts] Template schema should use HTTPS reference
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.RecoveryServices/vaults] Template schema should use HTTPS reference
…

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review December 6, 2021 19:35
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 6, 2021 19:35
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Dec 6, 2021
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change, 1 clarification

@AlexanderSehr AlexanderSehr merged commit 372d264 into main Dec 6, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/backupconfig branch December 6, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RSV: Add backup config

2 participants