Skip to content

Pipeline: Streamlining & improvements#768

Merged
AlexanderSehr merged 48 commits intomainfrom
users/alsehr/streamlinePipeline
Dec 11, 2021
Merged

Pipeline: Streamlining & improvements#768
AlexanderSehr merged 48 commits intomainfrom
users/alsehr/streamlinePipeline

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Dec 8, 2021

Change

  • Merged static validation actions to reduce pipeline & time consumption
  • Moved template validation into deploy composite action to have one single action for the template validation & reduce complexity
  • Renamed the composite actions to make more sense
  • Improved pipeline handling of deploymentName
  • Prepares structure for a potential later implementation of individual module dependencies

Pipeline reference:
AnalysisServices: Servers
ApiManagement: Service
Authorization: PolicyAssignments

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2021

Unit Test Results

  1 files  ±0  1 suites  ±0   16s ⏱️ +2s
  2 tests  - 2  2 ✔️  - 2    0 💤 ±0  0 ±0 
35 runs   - 2  2 ✔️  - 2  33 💤 ±0  0 ±0 

Results for commit b6d7aab. ± Comparison against base commit d13ae5d.

This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [servers] should use on of the recent API version(s). Currently using [2017-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments] used resource type [policyAssignments] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]

♻️ This comment has been updated with latest results.

AlexanderSehr and others added 12 commits December 11, 2021 01:02
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 11, 2021 00:07
@AlexanderSehr AlexanderSehr requested a review from eriqua December 11, 2021 00:08
@AlexanderSehr AlexanderSehr merged commit a12da5b into main Dec 11, 2021
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] pipelines category: pipelines enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directory based deployment using Module deployment script only deploys the first file in the directory

2 participants