Skip to content

Update removal#810

Merged
eriqua merged 16 commits intousers/alsehr/removalImprovementfrom
users/erikag/removalImprovement
Dec 14, 2021
Merged

Update removal#810
eriqua merged 16 commits intousers/alsehr/removalImprovementfrom
users/erikag/removalImprovement

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Dec 14, 2021

Change

  • PS Parameter names to PascalCase
  • Scope values to lowercase
  • Refactor Invoke-ResourceRemoval input to object for consistency with Invoke-PostResourceRemoval
  • Refactor API management removal to leverage Invoke-AzRestMethod ApiManagement: Service
  • Enable Insights: DiagnosticSettings removal Insights: DiagnosticSettings

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added this to the v 0.4 milestone Dec 14, 2021
@eriqua eriqua requested a review from AlexanderSehr December 14, 2021 01:01
@eriqua eriqua self-assigned this Dec 14, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 14, 2021

Unit Test Results

  1 files  1 suites   17s ⏱️
  6 tests 6 ✔️   0 💤 0
38 runs  6 ✔️ 32 💤 0

Results for commit 729daf0.

♻️ This comment has been updated with latest results.

@eriqua eriqua merged commit 4318ec4 into users/alsehr/removalImprovement Dec 14, 2021
@AlexanderSehr AlexanderSehr deleted the users/erikag/removalImprovement branch December 22, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants