Skip to content

Fix Storage Account MI Issue#861

Merged
MariusStorhaug merged 13 commits intomainfrom
users/mast/MIFix
Jan 6, 2022
Merged

Fix Storage Account MI Issue#861
MariusStorhaug merged 13 commits intomainfrom
users/mast/MIFix

Conversation

@MariusStorhaug
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug commented Jan 6, 2022

Change

Storage: StorageAccounts -> Though this could be lying! :D

Added extra condition on systemAssignedPrincipalId to check if there is principal ID in the identity property of the deployed resource. Currently it seems flaky from the API if this is returned or not. So seems like a backend issue.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug self-assigned this Jan 6, 2022
@MariusStorhaug MariusStorhaug added bug Something isn't working [cat] modules category: modules labels Jan 6, 2022
@MariusStorhaug MariusStorhaug linked an issue Jan 6, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug linked an issue Jan 6, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug added this to the v 0.4 milestone Jan 6, 2022
@MariusStorhaug MariusStorhaug linked an issue Jan 6, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) January 6, 2022 08:43
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@MariusStorhaug MariusStorhaug merged commit cd0b170 into main Jan 6, 2022
@AlexanderSehr AlexanderSehr deleted the users/mast/MIFix branch January 6, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] modules category: modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage account - output issue for blob endpoint Storage account: Deployment fails in main (Identity issue)

2 participants