Update Analysis Service and API Management Outputs

[senavar]

Change

Feel free to remove this sample text

Thank you for your contribution !

Update the output names for the Analysis Service and API Management modules

Type of Change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• My corresponding pipelines / checks run clean and green without any errors or warnings
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (readme)
• I did format my code

[github-actions]

Unit Test Results

    1 files  ±    0    1 suites  ±0   3m 17s ⏱️ + 2m 19s
  35 tests +  23  35 ✔️ +23      0 💤 ±    0  0 ❌ ±0 
487 runs  +323  35 ✔️ +23  452 💤 +300  0 ❌ ±0 

Results for commit 3a2402c. ± Comparison against base commit a3ab0b7.

This pull request removes 12 and adds 35 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults/backupConfig] used resource type [vaults/backupconfig] should use on of the recent API version(s). Currently using [2021-10-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults/backupPolicies] used resource type [vaults/backupPolicies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults/backupStorageConfig] used resource type [vaults/backupstorageconfig] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults/protectionContainers] used resource type [vaults/backupFabrics/protectionContainers] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [vaults/backupFabrics/protectionContainers] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [vaults/backupPolicies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [vaults/backupconfig] should use on of the recent API version(s). Currently using [2021-10-01]
…

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apiVersionSets] used resource type [service/apiVersionSets] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis/policies] used resource type [service/apis/policies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis] used resource type [service/apis/policies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis] used resource type [service/apis] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/authorizationServers] used resource type [service/authorizationServers] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/backends] used resource type [service/backends] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/caches] used resource type [service/caches] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/identityProviders] used resource type [service/identityProviders] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/namedValues] used resource type [service/namedValues] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/policies] used resource type [service/policies] should use on of the recent API version(s). Currently using [2021-08-01]
…

♻️ This comment has been updated with latest results.

[eriqua]

Hi @senavar last thing if you can. Could you please try running the API Management pipeline from your users/senavar/outputRefactor branch and attach the pipeline status badge in the PR description? Thanks!

[AlexanderSehr]

Hi @senavar last thing if you can. Could you please try running the API Management pipeline from your users/senavar/outputRefactor branch and attach the pipeline status badge in the PR description? Thanks!

Took the liberty:

A couple tests failed. And with @rahalan changes we also have a bunch of conflicts to resolve. Maybe @rahalan can help you out with that

[senavar]

Hi @senavar last thing if you can. Could you please try running the API Management pipeline from your users/senavar/outputRefactor branch and attach the pipeline status badge in the PR description? Thanks!

Took the liberty:

A couple tests failed. And with @rahalan changes we also have a bunch of conflicts to resolve. Maybe @rahalan can help you out with that

So I looked into the errors and its rather odd. It is saying that the readme output does not have all the outputs in the template file. Which is unexpected, as the readme script was ran for all files using the For-Each loop. Also checked the culprit readme and template file side-by-side. I don't see anything wrong. Can one of you also do a sanity check and make sure I'm not going crazy? @MrMCake @eriqua

[AlexanderSehr]

Hey @senavar, I fixed the issue. The problem was as follows:
By renaming the resourceId output in the products template to just resourceId, the also used function resourceId() could not be used anymore (i.e. bicep is unable to differentate the output name from the function (duh)). I updated it now to a different implementation that returns the ID from the module deployment outputs (api + groups) directly.

[senavar]

Hey @senavar, I fixed the issue. The problem was as follows: By renaming the resourceId output in the products template to just resourceId, the also used function resourceId() could not be used anymore (i.e. bicep is unable to differentate the output name from the function (duh)). I updated it now to a different implementation that returns the ID from the module deployment outputs (api + groups) directly.

Thanks! Will make note of this as I work through other modules and adjust as needed. Looks like the pipeline is now green and all good to go for merging :)

Pipeline badge is attached & green. All other comments are met