Skip to content

Dependency pipeline Replace msiPrincipalId at runtime#893

Merged
eriqua merged 69 commits intomainfrom
users/erikag/dep-msi-id-token
Jan 20, 2022
Merged

Dependency pipeline Replace msiPrincipalId at runtime#893
eriqua merged 69 commits intomainfrom
users/erikag/dep-msi-id-token

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Jan 16, 2022

Change

msi principal id is retrieved at runtime as an output of the user assigned identity module and used by the next modules deployed by the dependency pipeline.
It is not needed to create an msi manually or to deploy the dependency pipeline twice anymore.
Updated validate deploy action and ADO template to accept an additional optional parameter in json format to allow additional custom tokens to be replaced by the token replacement step. That is needed by the dependency pipeline change and transparent for pipelines not needing it.
The change is valid for both GH and ADO
.Platform: Dependencies

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added [cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] pipelines category: pipelines labels Jan 17, 2022
@eriqua eriqua self-assigned this Jan 17, 2022
@eriqua eriqua added this to the v 0.4 milestone Jan 17, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 17, 2022

Unit Test Results

  1 files  ±    0  1 suites  ±0   19s ⏱️ -39s
  4 tests  -     8  4 ✔️  - 8    0 💤 ±    0  0 ±0 
35 runs   - 129  4 ✔️  - 8  31 💤  - 121  0 ±0 

Results for commit 3bf2856. ± Comparison against base commit a3ab0b7.

This pull request removes 12 and adds 4 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults/backupConfig] used resource type [vaults/backupconfig] should use on of the recent API version(s). Currently using [2021-10-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults/backupPolicies] used resource type [vaults/backupPolicies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults/backupStorageConfig] used resource type [vaults/backupstorageconfig] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults/protectionContainers] used resource type [vaults/backupFabrics/protectionContainers] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [vaults/backupFabrics/protectionContainers] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [vaults/backupPolicies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.RecoveryServices/vaults] used resource type [vaults/backupconfig] should use on of the recent API version(s). Currently using [2021-10-01]
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DesktopVirtualization/hostpools] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DesktopVirtualization/hostpools] used resource type [hostPools] should use on of the recent API version(s). Currently using [2021-07-12]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DesktopVirtualization/hostpools] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DesktopVirtualization/hostpools] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]

♻️ This comment has been updated with latest results.

@eriqua eriqua marked this pull request as ready for review January 17, 2022 18:38
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@eriqua eriqua merged commit cccfbe3 into main Jan 20, 2022
@AlexanderSehr AlexanderSehr deleted the users/erikag/dep-msi-id-token branch January 20, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] pipelines category: pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants