Dependency pipeline Replace msiPrincipalId at runtime#893
Merged
Conversation
added 30 commits
January 14, 2022 17:45
added 15 commits
January 17, 2022 17:44
Unit Test Results 1 files ± 0 1 suites ±0 19s ⏱️ -39s Results for commit 3bf2856. ± Comparison against base commit a3ab0b7. This pull request removes 12 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
msi principal id is retrieved at runtime as an output of the user assigned identity module and used by the next modules deployed by the dependency pipeline.

It is not needed to create an msi manually or to deploy the dependency pipeline twice anymore.
Updated validate deploy action and ADO template to accept an additional optional parameter in json format to allow additional custom tokens to be replaced by the token replacement step. That is needed by the dependency pipeline change and transparent for pipelines not needing it.
The change is valid for both GH and ADO
Type of Change
Please delete options that are not relevant.
Checklist