Skip to content

Replaced CuaID implementation (to be discussed)#895

Merged
AlexanderSehr merged 21 commits intomainfrom
users/alsehr/882_cuaId
Mar 10, 2022
Merged

Replaced CuaID implementation (to be discussed)#895
AlexanderSehr merged 21 commits intomainfrom
users/alsehr/882_cuaId

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jan 17, 2022

Change

  • Replaced CuaID implementation with single-file solution
  • Added repository setting for telemetry GUID
  • Added implementation to optionally pass ID to template via pipeline (both GH & ADO)

Pipeline reference

Platform Pipeline
GitHub AnalysisServices: Servers
Azure DevOps IaCS

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Jan 17, 2022
@AlexanderSehr AlexanderSehr marked this pull request as draft January 17, 2022 12:47
@AlexanderSehr AlexanderSehr added [cat] modules category: modules help wanted Extra attention is needed labels Jan 17, 2022
@AlexanderSehr AlexanderSehr linked an issue Jan 17, 2022 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 17, 2022

Unit Test Results

  1 files  1 suites   19s ⏱️
  4 tests 4 ✔️   0 💤 0
36 runs  4 ✔️ 32 💤 0

Results for commit 3e7bda0.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr changed the title Replaced CuaID implementation Replaced CuaID implementation (to be discussed) Jan 17, 2022
@AlexanderSehr AlexanderSehr requested a review from mblant February 8, 2022 17:30
@AlexanderSehr AlexanderSehr marked this pull request as ready for review March 1, 2022 17:35
Copy link
Copy Markdown

@mblant mblant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change enableDefaultTelemetry to true by default?

@AlexanderSehr
Copy link
Copy Markdown
Contributor Author

Can we change enableDefaultTelemetry to true by default?

Hey @mblant, it is actually enabled by default via the settings.json config that is injected into each CI deployment. However, I now set it to true in the templates themselves.

From a consumer perpective, that means, they'd need to actively it in the settings.json when running the CI pipelines, and actively add a parameter to set the telemetry to false when building a solution with the templates.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) March 10, 2022 17:24
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just get it in.

@AlexanderSehr AlexanderSehr merged commit 9518f36 into main Mar 10, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/882_cuaId branch March 10, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CuaID implementation

3 participants