Update Key vault with security recommendation by elbatane · Pull Request #896 · Azure/ResourceModules

elbatane · 2022-01-17T16:17:45Z

Change

Updated parameters descriptions in main README:
- networkAcls
- privateEndpoints
- diagnosticEventHubName.
- diagnosticStorageAccountId
- diagnosticWorkspaceId
Updated parameters.json: added example of networkAcls and privateEndpoints object values.
Updated parameters descriptions in keys and secrets README:
- attributesExp.

Badge:
Close #783

Type of Change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update (Wiki)

Checklist

I'm sure there are no other open Pull Requests for the same update/change
My corresponding pipelines / checks run clean and green without any errors or warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (readme)
I did format my code

…ubresources

arm/Microsoft.KeyVault/vaults/.parameters/parameters.json

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

arm/Microsoft.KeyVault/vaults/keys/readme.md

arm/Microsoft.KeyVault/vaults/readme.md

arm/Microsoft.KeyVault/vaults/secrets/readme.md

eriqua

Thanks for the great work! After reviewing the suggestions could you please run the corresponding pipelines on your branch users/elanzelm/keyvault and paste the status badge to the PR body?

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

github-actions · 2022-01-18T17:00:20Z

Unit Test Results

    1 files ±    0   1 suites ±0 59s ⏱️ - 2m 15s
  14 tests -   21 14 ✔️ - 21     0 💤 ±    0 0 ❌ ±0
136 runs - 351 14 ✔️ - 21 122 💤 - 330 0 ❌ ±0

Results for commit 217d54a. ± Comparison against base commit dd6a5cb.

This pull request removes 35 and adds 14 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apiVersionSets] used resource type [service/apiVersionSets] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis/policies] used resource type [service/apis/policies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis] used resource type [service/apis/policies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis] used resource type [service/apis] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/authorizationServers] used resource type [service/authorizationServers] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/backends] used resource type [service/backends] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/caches] used resource type [service/caches] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/identityProviders] used resource type [service/identityProviders] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/namedValues] used resource type [service/namedValues] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/policies] used resource type [service/policies] should use on of the recent API version(s). Currently using [2021-08-01]
…

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/accessPolicies] used resource type [vaults/accessPolicies] should use on of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [vaults/keys] should use on of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [vaults/secrets] should use on of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints/privateDnsZoneGroups] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
…

♻️ This comment has been updated with latest results.

elbatane · 2022-01-19T08:25:25Z

Thanks for the great work! After reviewing the suggestions could you please run the corresponding pipelines on your branch users/elanzelm/keyvault and paste the status badge to the PR body?

Hi Erika, we have added the badge as you mentioned. Thanks

elbatane

Reviewed

elbatane

Reviewed

eriqua

🆗

elenabatanero added 8 commits December 13, 2021 19:55

Updated key vault

2dff5dd

removed default value for attributesExp param within Key and secret s…

658d43c

…ubresources

Updated key vault

4f47bd1

Merge branch 'main' into users/elanzelm/keyvault

bef382d

Testing parameters

349f9f7

Updated key vault with security recommendations

9b24c5f

upodated key vault with security recommendations

1d432ce

Merge remote-tracking branch 'origin/main' into users/elanzelm/keyvault

5cde128

elbatane assigned elbatane and elanzel Jan 17, 2022

elbatane added [cat] modules category: modules enhancement New feature or request labels Jan 17, 2022

elbatane added this to the v 0.4 milestone Jan 17, 2022

eriqua reviewed Jan 17, 2022

View reviewed changes

arm/Microsoft.KeyVault/vaults/.parameters/parameters.json Outdated Show resolved Hide resolved

Update arm/Microsoft.KeyVault/vaults/.parameters/parameters.json

0042b47

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>