Conversation
eriqua
left a comment
There was a problem hiding this comment.
Looks good! I'm wondering:
- Should we consistently update also nested pip modules across the repo (e.g. the one in the vm)?
- Should we extend the parameter file(s) with new values?
|
We have a discussion today about module dependencies. The outcome may be, that we will reference just this one PIP module. |
Makes sense but implies low priority effort. It also screams for a nested module dependency list then. |
Even better, which would also eliminate my previous comment about the need of a nested dependencies list then, Thanks. |
Unit Test Results 1 files ± 0 1 suites ±0 21s ⏱️ - 2m 53s Results for commit e0656d5. ± Comparison against base commit dd6a5cb. This pull request removes 35 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Change
Adding some additional parameters and adding allowed values to existing ones
successful run:
Type of Change
Please delete options that are not relevant.
Checklist