Skip to content

Switch description outputs#963

Merged
eriqua merged 2 commits intoAzure:mainfrom
modbase:patch-1
Feb 4, 2022
Merged

Switch description outputs#963
eriqua merged 2 commits intoAzure:mainfrom
modbase:patch-1

Conversation

@modbase
Copy link
Copy Markdown
Contributor

@modbase modbase commented Feb 3, 2022

Resource Group name and Availability Set name where exchanged

Change

The description of the Resource Group and Availability Set name outputs where switched.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Resource Group name and Availability Set name where exchanged
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @modbase and thanks a lot for this. Could you also update the corresponding readme file? You can do this manually or using our Module ReadMe Generation Script utility https://github.com/Azure/ResourceModules/wiki/UtilitiesSetModuleReadMe

@ghost
Copy link
Copy Markdown

ghost commented Feb 4, 2022

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua merged commit f61dcc6 into Azure:main Feb 4, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules bug Something isn't working labels Feb 4, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Feb 4, 2022
@modbase modbase deleted the patch-1 branch February 4, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] modules category: modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants