Users/alsehr/849 local test by AlexanderSehr · Pull Request #968 · Azure/ResourceModules

AlexanderSehr · 2022-02-04T15:27:33Z

Change

Enabled local tests to run with a provided parameter file
Simplified token handling in script
Simplified token handling in pipeline
Simplified settings.json token handling
Updated documentation

Pipeline references

@ ADO Dependency pipeline:

Type of Change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update (Wiki)

.../pipelines/dependencies/Microsoft.Authorization/policyAssignments/parameters/parameters.json

utilities/pipelines/tokensReplacement/Convert-TokensInParameterFile.ps1

settings.json

github-actions · 2022-02-08T08:52:07Z

Unit Test Results

  1 files ±0 1 suites ±0 19s ⏱️ -1s
  3 tests ±0 3 ✔️ ±0   0 💤 ±0 0 ❌ ±0
35 runs ±0 3 ✔️ ±0 32 💤 ±0 0 ❌ ±0

Results for commit e0e20e7. ± Comparison against base commit f61dcc6.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/availabilitySets] used resource type [availabilitySets] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/availabilitySets] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/availabilitySets] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/routeTables] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/routeTables] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/routeTables] used resource type [routeTables] should use on of the recent API version(s). Currently using [2021-05-01]

♻️ This comment has been updated with latest results.

.azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml

docs/wiki/UtilitiesTestModuleLocally.md

utilities/pipelines/tokensReplacement/Convert-TokensInParameterFile.ps1

utilities/tools/Test-ModuleLocally.ps1

ahmadabdalla · 2022-02-08T23:49:15Z

Something I noticed

VERBOSE: {
  "ResourceGroupName": "validation-rg",
  "TemplateFilePath": "/home/runner/work/ResourceModules/ResourceModules/arm/Microsoft.AnalysisServices/servers/deploy.bicep",
  "ManagementGroupId": "***",
  "Verbose": true,
  "DeploymentName": "servers-20220208T1002332788Z"
}

VERBOSE: Template file path: [/home/runner/work/ResourceModules/ResourceModules/arm/Microsoft.AnalysisServices/servers/deploy.bicep]
VERBOSE: Module name: [servers]
VERBOSE: Handling resource removal with deployment name [servers-20220208T1002332788Z]
VERBOSE: Determined deployment scope [resourcegroup]
VERBOSE: Found deployed resource [/subscriptions/***/resourceGroups/validation-rg/providers/Microsoft.AnalysisServices/servers/sxxazasweumin001]
VERBOSE: Total number of deployment target resources after fetching deployments [1]
VERBOSE: Total number of deployment target resources  after pre-filtering (duplicates) & ordering items [1]
VERBOSE: Total number of deployment target resources after formatting items [1]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]

which I found here.
Can't seem to see why all that verbosing is happening for a single token. Thoughts?

AlexanderSehr · 2022-02-09T07:40:20Z

Something I noticed

VERBOSE: {
  "ResourceGroupName": "validation-rg",
  "TemplateFilePath": "/home/runner/work/ResourceModules/ResourceModules/arm/Microsoft.AnalysisServices/servers/deploy.bicep",
  "ManagementGroupId": "***",
  "Verbose": true,
  "DeploymentName": "servers-20220208T1002332788Z"
}

VERBOSE: Template file path: [/home/runner/work/ResourceModules/ResourceModules/arm/Microsoft.AnalysisServices/servers/deploy.bicep]
VERBOSE: Module name: [servers]
VERBOSE: Handling resource removal with deployment name [servers-20220208T1002332788Z]
VERBOSE: Determined deployment scope [resourcegroup]
VERBOSE: Found deployed resource [/subscriptions/***/resourceGroups/validation-rg/providers/Microsoft.AnalysisServices/servers/sxxazasweumin001]
VERBOSE: Total number of deployment target resources after fetching deployments [1]
VERBOSE: Total number of deployment target resources  after pre-filtering (duplicates) & ordering items [1]
VERBOSE: Total number of deployment target resources after formatting items [1]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]
VERBOSE: Using local tokens [namePrefix]

which I found here. Can't seem to see why all that verbosing is happening for a single token. Thoughts?

Seems its due to the resource removal where we fetch the resources names using the local tokens. Removed the verbosity

ahmadabdalla

No further comments from my side. Approved

AlexanderSehr added 13 commits February 4, 2022 10:17

First commit

4f0acdf

Updated interface

6574b0b

Refactored file logic

9fd3f16

Further refactoring

e02f58a

Continued iteration

b1c3955

Update to latest

c6115e8

Futher updated structure

bf8d643

Updated pipelines

8393dbd

Added conversion

c02d00f

Fixed dependencyies

339ec04

Small fix

8a008d4

Updated documentation

f331ffb

Cleanup

22a3ce9

AlexanderSehr self-assigned this Feb 4, 2022

AlexanderSehr added [cat] pipelines category: pipelines [prio] high importance of the issue: high priority documentation Improvements or additions to documentation enhancement New feature or request labels Feb 4, 2022

AlexanderSehr added this to the v 0.4 milestone Feb 4, 2022

AlexanderSehr commented Feb 4, 2022

View reviewed changes

.../pipelines/dependencies/Microsoft.Authorization/policyAssignments/parameters/parameters.json Outdated Show resolved Hide resolved

AlexanderSehr added 2 commits February 4, 2022 16:29

Rollback dependency file changes

03cd3e6

Further rollbacks

7ae14bb

AlexanderSehr linked an issue Feb 4, 2022 that may be closed by this pull request

Test-ScriptLocally script works with incorrect assumptions #849

Closed

AlexanderSehr added 7 commits February 4, 2022 17:19

Small update

9df1eaf

Minor update

dc34b9e

Minor cleanup in docs

c09c5a0

Further simplificatin

eb929a3

Updated dependency pipeline & docs

aecc29a

Minor fix

1d0f4f0

Updated token handling

d9397c2

AlexanderSehr commented Feb 8, 2022

View reviewed changes

utilities/pipelines/tokensReplacement/Convert-TokensInParameterFile.ps1 Outdated Show resolved Hide resolved

AlexanderSehr commented Feb 8, 2022

View reviewed changes

utilities/pipelines/tokensReplacement/Convert-TokensInParameterFile.ps1 Outdated Show resolved Hide resolved

AlexanderSehr commented Feb 8, 2022

View reviewed changes

settings.json Outdated Show resolved Hide resolved

Updated settings.json

3267085

AlexanderSehr added 5 commits February 8, 2022 09:56

Minor fix

f40a355

added missing SA conversion

1792006

Fixed further locations

6ab377a

Renamed param

316f07b

Small fix

ca3d1cc

ahmadabdalla requested changes Feb 8, 2022

View reviewed changes

AlexanderSehr added 8 commits February 9, 2022 08:42

Changed casing

ca35930

Renamed file & parameters as per comments

177fc0f

Updated interface

22531fb

Update to latest

e1cff58

Updated docs

b8719b3

Changed input object buildup

ebee028

Reduced verbosity

9d21a08

Reduced verbosity

e0e20e7

AlexanderSehr enabled auto-merge (squash) February 9, 2022 12:15

AlexanderSehr requested a review from ahmadabdalla February 9, 2022 12:15

ahmadabdalla approved these changes Feb 9, 2022

View reviewed changes

AlexanderSehr merged commit 9ba0d14 into main Feb 9, 2022

AlexanderSehr deleted the users/alsehr/849_localTest branch February 9, 2022 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Users/alsehr/849 local test#968

Users/alsehr/849 local test#968
AlexanderSehr merged 36 commits intomainfrom
users/alsehr/849_localTest

AlexanderSehr commented Feb 4, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 8, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahmadabdalla commented Feb 8, 2022

Uh oh!

AlexanderSehr commented Feb 9, 2022

Uh oh!

ahmadabdalla left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AlexanderSehr commented Feb 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change

Type of Change

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahmadabdalla commented Feb 8, 2022

Uh oh!

AlexanderSehr commented Feb 9, 2022

Uh oh!

ahmadabdalla left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AlexanderSehr commented Feb 4, 2022 •

edited

Loading

github-actions bot commented Feb 8, 2022 •

edited

Loading