Conversation
kairu-ms
reviewed
Jan 21, 2025
kairu-ms
reviewed
Jan 21, 2025
kairu-ms
reviewed
Jan 21, 2025
Comment on lines
1246
to
1263
| if self.is_in_memory: | ||
| return None | ||
| assert not self.is_in_memory |
Collaborator
There was a problem hiding this comment.
There must be some internal bugs, because the old code add assert below to guarantee it's not in memory . Could you find the reason why it's in memory.
Contributor
Author
There was a problem hiding this comment.
is_in_memory is true when the ws does not get saved in file system, (for cmd aaz-dev command-model generate-from-swagger), so it cannot be loaded from memory either.
AllyW
force-pushed
the
fix-autogen-cmd
branch
from
93e95bb to
79a9617
Compare
kairu-ms
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test cmd: