Provide short message for cmd if not exists#453
Merged
Conversation
kairu-ms
reviewed
Feb 21, 2025
src/aaz_dev/command/api/editor.py
Outdated
Comment on lines
+628
to
+641
| # provide default short summary | ||
| for node in manager.iter_command_tree_nodes(): | ||
| if not node.help: | ||
| node.help = CMDHelp() | ||
| if not node.help.short: | ||
| node.help.short = f"Manage {node.names[-1]}" | ||
|
|
||
| for leaf in manager.iter_command_tree_leaves(): | ||
| if not leaf.help: | ||
| leaf.help = CMDHelp() | ||
| if not leaf.help.short: | ||
| n = leaf.names[-1] | ||
| n = n[0].upper() + n[1:] | ||
| leaf.help.short = f"{n} {leaf.names[-2]}" |
Collaborator
There was a problem hiding this comment.
Please don't implement code in the api level. Please implement it in related code of command generation.
AllyW
force-pushed
the
support-auto-short-message
branch
2 times, most recently
from
6140ea0 to
05679e8
Compare
Contributor
Author
|
|
Contributor
Author
|
|
Collaborator
|
Please convert the name with space between. |
kairu-ms
reviewed
Feb 27, 2025
kairu-ms
reviewed
Feb 27, 2025
AllyW
force-pushed
the
support-auto-short-message
branch
from
e6c2b8e to
1d79cef
Compare
kairu-ms
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.