This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Add VnetIntegration switch to Kubernetes#1480
Closed
ofiliz wants to merge 2 commits intoAzure:masterfrom
Closed
Conversation
Member
|
Thanks @ofiliz I'll take a look |
Contributor
Author
|
Wow, I need to sign a CLA now! 😄 It took Microsoft just two days to forget who I am. 😆 |
Contributor
Author
|
@lachie83 Can we please get this done soon? The Windows CNI PR depends on this one. |
This was referenced Sep 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To solve the problems described in issue #1499, this PR adds a "vnetIntegration" property to KubernetesConfig. It defaults to disabled.
The existing "networkPolicy" property controls what the network policy provider is. The new "vnetIntegration" property controls whether VNET CNI plugins are enabled. This allows Calico to implement their network policy on top of our IPAM CNI plugin by setting vnetIntegration:"enabled" and networkPolicy:"calico". It also enables customers to immediately start using our VNET CNI plugin (with pods having access to Internet) by just setting vnetIntegration:"enabled".
The azure networkPolicy requires vnetIntegration to be enabled. This is forced in acs-engine. New test cases are added to validate behavior of all possible combinations.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1499Special notes for your reviewer:
I reordered some fields in KubernetesConfig to group similar fields together and make sure they are always read/parsed/passed in the same order for consistency. This isn't a must, but results in better code IMHO.
Release note:
@nisheeth-ms, @sharmasushant, @tamilmani1989, @lachie83, @anhowe
fixes #1499