This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Monitoring extension Grafana dashboard update#2274
Merged
jackfrancis merged 8 commits intoAzure:masterfrom Mar 9, 2018
Merged
Conversation
Contributor
Author
|
cc @ritazh |
Contributor
Author
|
Please do not merge yet. Working through an issue uncovered in #2142 |
Contributor
Author
tesharp
pushed a commit
to tesharp/acs-engine
that referenced
this pull request
Mar 16, 2018
* switch k8s dashboard source * (wip) change prometheus chart value to create rbac * revise prometheus relabeling to target cadvisor as a daemonset * add cadvisor ds * add functionality to the monitoring extension to install the cadvisor daemonset * modify readme to reflect cadvisor config url option * add replaceable string for the ds api group * add logic to alter the ds api group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: in the monitoring extension (prometheus-grafana), the current dashboard that is used does not appear to be even close to Prometheus v2 compatible. With the merging of #2257 which adds support for Prometheus v2, it is important that the plug-and-play Grafana dashboard provides the end user with as good of an experience as possible. With the new dashboard, it has more coverage for Prometheus v2.
Special notes for your reviewer:
Release note: