This repository was archived by the owner on Jan 11, 2023. It is now read-only.
fix #3190 only use nvidia-container-runtime on gpu nodes#3192
Closed
johnhofman wants to merge 1 commit intoAzure:masterfrom
Eneco:fix/hybrid-gpu-cpu
Closed
fix #3190 only use nvidia-container-runtime on gpu nodes#3192johnhofman wants to merge 1 commit intoAzure:masterfrom Eneco:fix/hybrid-gpu-cpu
johnhofman wants to merge 1 commit intoAzure:masterfrom
Eneco:fix/hybrid-gpu-cpu
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
Thanks @johnhofman! #3181 also addresses this issue and adds toleration for device plugin so it doesn't get scheduled on CPU nodes. I'll close this in favor of #3181 unless you see anything else missing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows deployment of a cluster with cpu and gpu agent pools with the nvidia-device-plugin enabled. Without this the docker daemon on the cpu nodes fails to start.
Which issue this PR fixes *
This fixes #3190 by only making the changes to
/etc/docker/daemon.jsonon gpu enabled nodes using the same template switch which enables/disables the installation of the GPU drivers.