This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Merged
Conversation
tariq1890
force-pushed
the
cleanup_err_usage
branch
from
18c51fa to
70489eb
Compare
CecileRobertMichon
approved these changes
Jul 16, 2018
Contributor
CecileRobertMichon
left a comment
CecileRobertMichon
left a comment
There was a problem hiding this comment.
lgtm, @tariq1890 you'll need to rebase to fix the unit test error
# Conflicts: # pkg/helpers/helpers_test.go
tariq1890
force-pushed
the
cleanup_err_usage
branch
from
5364894 to
17f42e5
Compare
tariq1890
commented
Jul 16, 2018
| p.ExtensionProfiles = test.extensionProfiles | ||
| err := p.Validate(true) | ||
| if !reflect.DeepEqual(err, test.expectedErr) { | ||
| if !helpers.EqualError(err, test.expectedErr) { |
Contributor
Author
There was a problem hiding this comment.
@CecileRobertMichon @jackfrancis FYI I changed this and added a new helper method as the reflect Deep Equals is a possible anti-pattern
Contributor
Author
|
@CecileRobertMichon Rebased! |
Member
|
@tariq1890 + @cpuguy83 ❤️ ❤️ ❤️ |
kkmsft
pushed a commit
to kkmsft/acs-engine
that referenced
this pull request
Jul 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Picking up from where #3386 left off. For consistency across entire project :)
Special notes for your reviewer:
If applicable:
Release note: