This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Remove allow_kube_tls rule when no masters as is not required#3693
Closed
marrobi wants to merge 1 commit intoAzure:masterfrom
Closed
Remove allow_kube_tls rule when no masters as is not required#3693marrobi wants to merge 1 commit intoAzure:masterfrom
marrobi wants to merge 1 commit intoAzure:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marrobi If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Aug 16, 2018
Contributor
|
I believe this is a duplicate of #4085 & #4164. If I'm wrong please reopen in https://github.com/Azure/aks-engine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the allow_kube_tls rule from the network security group. This rule allows traffic from Any source to any destination on port 443, and it being present prevents traffic inbound to 443 being further restricted on the NSG.
For example when creating a rule to restrict ingress traffic on 443 to a specified IP range using loadBalancerSourceRanges this has no affect as the allow_kube_tls allows all traffic.
The annotation on the allow_kube_tls rule is "Allow kube-apiserver (tls) traffic to master", if there are masters (i.e. not AKS), then the rule is still added (defined in kubernetesmasterresources.t ) in the existing code below:
Feedback welcome.
Special notes for your reviewer:
I cannot think of any issues removing this rule would create to existing users, I have manually removed it from a couple of my clusters and operations do not seem to be affected.
If applicable: