Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Stop kubelet before update and reboot faster#4107

Closed
PatrickLang wants to merge 4 commits intoAzure:masterfrom
PatrickLang:patricklang-stopkubeletbeforeupdate
Closed

Stop kubelet before update and reboot faster#4107
PatrickLang wants to merge 4 commits intoAzure:masterfrom
PatrickLang:patricklang-stopkubeletbeforeupdate

Conversation

@PatrickLang
Copy link
Contributor

What this PR does / why we need it:

If you're creating a cluster as part of a test pass - the nodes appear to be ready before any patches are installed. This change will stop the kubelet so the node is not "ready", and also reboot faster. Once the reboot happens - the kubelet will be running and the testing can commence.

cc @adelina-t

@acs-bot
Copy link

acs-bot commented Oct 24, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PatrickLang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: brendandburns

If they are not already assigned, you can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost ghost assigned PatrickLang Oct 24, 2018
@ghost ghost added the in progress label Oct 24, 2018
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #4107 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4107   +/-   ##
=======================================
  Coverage   55.44%   55.44%           
=======================================
  Files         109      109           
  Lines       16056    16056           
=======================================
  Hits         8903     8903           
  Misses       6369     6369           
  Partials      784      784

@PatrickLang
Copy link
Contributor Author

This was failing until #4119 & #4141 merged. Retesting now

@PatrickLang PatrickLang force-pushed the patricklang-stopkubeletbeforeupdate branch from 088d6e5 to fdf0848 Compare December 18, 2018 21:54
@PatrickLang
Copy link
Contributor Author

@adelina-t @dineshgovindasamy - I added the workaround to remove the Azure CNI lock after reboot. Can you review?

@PatrickLang
Copy link
Contributor Author

/hold

The scheduled task still doesn't run after reboot. If you run Get-ScheduledTask -TaskName "RemoveLock" | Start-ScheduledTask it will complete, but it never starts automatically. Need to dig more into this.

@CecileRobertMichon
Copy link
Contributor

@PatrickLang can you please move this to https://github.com/Azure/aks-engine?

@ghost ghost removed the in progress label Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants