WIP: Temporary fix for #4118 in acs-engine v0.24

[PatrickLang]

What this PR does / why we need it:

The October windows image MicrosoftWindowsServer:WindowsServerSemiAnnual:Datacenter-Core-1803-with-Containers-smalldisk:1803.0.20181017 brought in Docker EE-basic 18.03, which has a problem with Kubernetes v1.12 (kubernetes/kubernetes#69996)

This puts in a temporary workaround. The best fix to avoid this problem long term is to enable acs-engine to deploy a specific Docker version so they can be tested before release, and pinned if necessary. That fix is in #4119 but will be in acs-engine v0.25 later.

Which issue this PR fixes
fixes #4118

[acs-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PatrickLang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jackfrancis

If they are not already assigned, you can assign the PR to them by writing /assign @jackfrancis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[PatrickLang]

/hold
this needs manual testing - in progress right now

[PatrickLang]

This doesn't work yet. do not merge

[codecov]

Codecov Report

Merging #4134 into patch-release-v0.24.2 will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           patch-release-v0.24.2    #4134   +/-   ##
======================================================
  Coverage                  50.61%   50.61%           
======================================================
  Files                        109      109           
  Lines                      16965    16965           
======================================================
  Hits                        8586     8586           
  Misses                      7584     7584           
  Partials                     795      795

[PatrickLang]

/hold cancel

[PatrickLang]

/meow

[acs-bot]

@PatrickLang:

Details

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[PatrickLang]

Ok, working now

$ kubectl get node
NAME                    STATUS    ROLES     AGE       VERSION
39001k8s9000            Ready     agent     4m40s     v1.12.1
39001k8s9001            Ready     agent     4m57s     v1.12.1
k8s-master-39001978-0   Ready     master    7m35s     v1.12.1

patrick@plang-h1:~/plang1029$ kubectl get node -o wide
NAME                    STATUS    ROLES     AGE       VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                    KERNEL-VERSION   CONTAINER-RUNTIME
39001k8s9000            Ready     agent     4m57s     v1.12.1   10.240.0.65   <none>        Windows Server Datacenter   10.0.17134.345
                        docker://18.3.1
39001k8s9001            Ready     agent     5m14s     v1.12.1   10.240.0.4   <none>    Windows Server Datacenter   10.0.17134.345
                        docker://18.3.1
k8s-master-39001978-0   Ready     master    7m52s     v1.12.1   10.255.255.5   <none>    Ubuntu 16.04.5 LTS   4.15.0-1023-azure   docker://1.13.1

[PatrickLang]

I have a comment in there not to merge this to master. We'll get the master branch moved up to Docker 18.09 which doesn't need this workaround.

[PatrickLang]

I will be updating this to build on top of #4119 instead