Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Disable accelerated networking for PB series VMs#4332

Closed
tariq1890 wants to merge 1 commit intoAzure:masterfrom
tariq1890:acc_net_pb
Closed

Disable accelerated networking for PB series VMs#4332
tariq1890 wants to merge 1 commit intoAzure:masterfrom
tariq1890:acc_net_pb

Conversation

@tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Dec 3, 2018

This is needed in tandem with #4265 . Currently, it is known that PB series VMs have no accelerated Networking support.

We are forced to use/edit these static lists as we have no api from Azure to retrieve VM Skus and their properties :(

@ghost ghost assigned tariq1890 Dec 3, 2018
@ghost ghost added the in progress label Dec 3, 2018
@tariq1890 tariq1890 requested a review from jackfrancis December 3, 2018 19:51
@CecileRobertMichon
Copy link
Contributor

Description? why is this needed/true? is there a relevant doc?

@tariq1890 tariq1890 requested a review from kkmsft December 3, 2018 20:13
@tariq1890
Copy link
Contributor Author

@CecileRobertMichon I've updated the PR

@CecileRobertMichon
Copy link
Contributor

@tariq1890 did this make it in aks-engine? Should we close this one?

@tariq1890
Copy link
Contributor Author

Yes. Closing.

@tariq1890 tariq1890 closed this Dec 14, 2018
@ghost ghost removed the in progress label Dec 14, 2018
@tariq1890 tariq1890 deleted the acc_net_pb branch December 14, 2018 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants