[WIP - Do not Merge] Feat - Clusters without public IPs#674
[WIP - Do not Merge] Feat - Clusters without public IPs#674lachie83 wants to merge 4 commits intoAzure:masterfrom
Conversation
|
Can one of the admins verify this patch? |
| "properties": { | ||
| "orchestratorProfile": { | ||
| "orchestratorType": "Kubernetes", | ||
| "kubernetesConfig": { |
There was a problem hiding this comment.
Instead of adding another config for specifying this the absence of dnsPrefix on master pool can be used as a choice for no public ip. Otherwise if someone specifies "noPublicIP": true and set dnsPrefix on master what would be the expected architecture?
There was a problem hiding this comment.
Yeah that's a great point. I had originally thought I could use the FQDN to reference the ILB but that doesn't appear to be the case. I've got a bunch of questions about how this should be implemented in the issue #221. Please feel free to let me know the best way to proceed.
There was a problem hiding this comment.
@lachie83 , IsCustomVNET func in types.go and its usage in this file [{{if .IsCustomVNET}}] is an example of how this can be done for nopublic ip case as well.
|
@lachie83 - Have you implemented all changes required from review ? |
|
@shrutir25 not as of yet. If anyone else has made more progress then we can abandon this one. |
|
closing in favor of #2326 |
ghost
removed
the
10 participants
What this PR does / why we need it:
Allows the provisioning of Kubernetes clusters without Public IP addresses
Which issue this PR fixes: fixes #221
Special notes for your reviewer:
Release note:
This change is