frontend: Update failing snapshots#574
Draft
skoeva wants to merge 1 commit intoAzure:headlamp-downstreamfrom
Draft
frontend: Update failing snapshots#574skoeva wants to merge 1 commit intoAzure:headlamp-downstreamfrom
skoeva wants to merge 1 commit intoAzure:headlamp-downstreamfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Storybook storyshot file snapshots to match current rendered DOM output from make frontend-test, likely after recent dependency/style changes (e.g., MUI/Emotion class hash updates).
Changes:
- Refreshed many storyshot snapshots where MUI/Emotion-generated
css-<hash>classnames changed. - Updated snapshots for multiple resource detail tables (services, ingresses, HPAs/VPAs, gateways, webhooks, etc.).
- Updated Plugin Settings storyshots to include newly rendered “Back” button markup in several scenarios.
Reviewed changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/webhookconfiguration/snapshots/ValidatingWebhookConfigDetails.WithURL.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/webhookconfiguration/snapshots/ValidatingWebhookConfigDetails.WithService.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/webhookconfiguration/snapshots/MutatingWebhookConfigDetails.WithURL.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/webhookconfiguration/snapshots/MutatingWebhookConfigDetails.WithService.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/verticalPodAutoscaler/snapshots/VPADetails.Default.stories.storyshot | Snapshot updates for multiple tables (MUI classname hash changes). |
| frontend/src/components/service/snapshots/ServiceDetails.WithA8ROwnerOnly.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/service/snapshots/ServiceDetails.WithA8RAnnotations.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/service/snapshots/ServiceDetails.ErrorWithEndpoints.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/service/snapshots/ServiceDetails.Default.stories.storyshot | Snapshot updates for multiple tables (MUI classname hash changes). |
| frontend/src/components/resourceQuota/snapshots/resourceQuotaDetails.Default.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/ingress/snapshots/Details.WithTLS.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/ingress/snapshots/Details.WithResource.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/horizontalPodAutoscaler/snapshots/HPADetails.Default.stories.storyshot | Snapshot updates for multiple tables (MUI classname hash changes). |
| frontend/src/components/gateway/snapshots/HTTPRouteDetails.Basic.stories.storyshot | Snapshot updates for multiple tables (MUI classname hash changes). |
| frontend/src/components/gateway/snapshots/GRPCRouteDetails.Basic.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/endpointSlices/snapshots/EndpointSliceDetails.Default.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/endpoints/snapshots/EndpointDetails.Default.stories.storyshot | Snapshot updates for multiple tables (MUI classname hash changes). |
| frontend/src/components/crd/snapshots/CustomResourceDefinition.Details.stories.storyshot | Snapshot updates for multiple tables (MUI classname hash changes). |
| frontend/src/components/common/snapshots/SimpleTable.UIDSearch.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.ReflectInURLWithPrefix.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.ReflectInURL.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.NumberSearch.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.NotFoundMessage.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.NamespaceSelect.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.NamespaceSearch.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.NameSearch.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.LabelSearch.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.Getter.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/SimpleTable.Datum.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/ObjectEventList.WithEvents.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/InnerTable.WithoutTableHeader.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/InnerTable.WithFewRows.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/InnerTable.InsideAnotherComponent.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/common/snapshots/InnerTable.Default.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/App/Settings/snapshots/SettingsClusters.VariousConfigurations.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/App/Settings/snapshots/SettingsClusters.SingleCluster.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/App/Settings/snapshots/SettingsClusters.ManyClusters.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/App/Settings/snapshots/SettingsClusters.LongNamesAndURLs.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/App/Settings/snapshots/SettingsClusters.ClusterListDisplay.stories.storyshot | Snapshot update (MUI table classname hash change). |
| frontend/src/components/App/PluginSettings/snapshots/PluginSettings.MultipleLocations.stories.storyshot | Snapshot update; now includes Back button markup plus MUI classname hash changes. |
| frontend/src/components/App/PluginSettings/snapshots/PluginSettings.MoreItems.stories.storyshot | Snapshot update; now includes Back button markup plus MUI classname hash changes. |
| frontend/src/components/App/PluginSettings/snapshots/PluginSettings.MigrationScenario.stories.storyshot | Snapshot update; now includes Back button markup plus MUI classname hash changes. |
| frontend/src/components/App/PluginSettings/snapshots/PluginSettings.ManyItems.stories.storyshot | Snapshot update; now includes Back button markup plus MUI classname hash changes. |
| frontend/src/components/App/PluginSettings/snapshots/PluginSettings.FewItems.stories.storyshot | Snapshot update; now includes Back button markup plus MUI classname hash changes. |
| frontend/src/components/App/PluginSettings/snapshots/PluginSettings.EmptyHomepageItems.stories.storyshot | Snapshot update; now includes Back button markup plus MUI classname hash changes. |
| frontend/src/components/App/PluginSettings/snapshots/PluginSettings.Empty.stories.storyshot | Snapshot update; now includes Back button markup plus MUI classname hash changes. |
| frontend/src/components/App/PluginSettings/snapshots/PluginSettings.DefaultSaveEnable.stories.storyshot | Snapshot update; now includes Back button markup plus MUI classname hash changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
e02d8b6 to
f245a68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes update the failing snapshots in the CI from
make frontend-test.