This repository was archived by the owner on Oct 24, 2023. It is now read-only.
fix: clean generated and unit test helper files#1151
Merged
acs-bot merged 1 commit intoAzure:masterfrom Apr 25, 2019
Merged
Conversation
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold until #1088 is merged, since that will have us check in the generated go files intentionally. |
Codecov Report
@@ Coverage Diff @@
## master #1151 +/- ##
=========================================
Coverage ? 74.43%
=========================================
Files ? 131
Lines ? 18317
Branches ? 0
=========================================
Hits ? 13634
Misses ? 3902
Partials ? 781 |
Member
Author
|
/hold cancel |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
make cleanby tradition should clean up all generated and temporary files. This adds some droppings that were missed.Issue Fixed:
Requirements:
Notes: