This repository was archived by the owner on Oct 24, 2023. It is now read-only.
chore: update client-go and k8s.io vendored code#1273
Merged
acs-bot merged 1 commit intoAzure:masterfrom May 9, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
=======================================
Coverage 74.84% 74.84%
=======================================
Files 128 128
Lines 18338 18338
=======================================
Hits 13725 13725
Misses 3829 3829
Partials 784 784 |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
As long as the lib is updated I'm fine :) 👍 |
This was referenced May 28, 2019
mboersma
added a commit
to mboersma/aks-engine
that referenced
this pull request
Jun 21, 2019
This reverts commit 0ce726b.
mboersma
added a commit
to mboersma/aks-engine
that referenced
this pull request
Jun 21, 2019
This reverts commit 0ce726b.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Updates
k8s.iovendored imports to more current versions.Issue Fixed:
Should fix an error upgrading or scaling an AAD-enabled cluster:
and unblock the OpenShift team trying to vendor in a RedHat plugin.
Closes #506
See also Azure/acs-engine#4296 and #85.
Requirements:
Notes:
@skinny I tried to put a commit on top of #506 but ran into "filename too long errors" just trying to check out the branch and wasn't able to work around it (I think some Unix symlinks got checked in?) So I started fresh here, but if you'd rather rehab #506 let me know and we can work with that.