Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sylr If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sylr Thanks for this PR. Since |
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 53.21% 53.19% -0.03%
==========================================
Files 95 95
Lines 14230 14230
==========================================
- Hits 7573 7569 -4
- Misses 5991 5995 +4
Partials 666 666 |
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 53.25% 53.25%
=======================================
Files 95 95
Lines 14246 14246
=======================================
Hits 7586 7586
Misses 5995 5995
Partials 665 665 |
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
|
@sylr Can you rebase this ? |
|
Ok |
tariq1890
left a comment
There was a problem hiding this comment.
lgtm. Pending review of @jackfrancis and @mboersma
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Uh oh!
There was an error while loading. Please reload this page.