Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

Conversation

@mboersma
Copy link
Member

@mboersma mboersma commented Nov 15, 2018

What this PR does / why we need it:

Extends #23 to add headers to shell scripts and the lone Python file in the repository.

(Also gives me a simple PR with which to ensure our CircleCI setup is working.)

Which issue this PR fixes:

Refs #12

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Add copyright header to source code that isn't Go

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   46.89%   46.89%           
=======================================
  Files          91       91           
  Lines       13800    13800           
=======================================
  Hits         6471     6471           
  Misses       6721     6721           
  Partials      608      608

@jackfrancis
Copy link
Member

/lgtm

@jackfrancis jackfrancis merged commit 1aa131d into Azure:master Nov 16, 2018
@acs-bot
Copy link

acs-bot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the more-license-headers branch November 16, 2018 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants