This repository was archived by the owner on Oct 24, 2023. It is now read-only.
refactor: change MCR base URL to /oss/kubernetes/#2479
Closed
mboersma wants to merge 1 commit intoAzure:masterfrom
Closed
refactor: change MCR base URL to /oss/kubernetes/#2479mboersma wants to merge 1 commit intoAzure:masterfrom
mboersma wants to merge 1 commit intoAzure:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #2479 +/- ##
=======================================
Coverage 72.53% 72.53%
=======================================
Files 130 130
Lines 23919 23919
=======================================
Hits 17349 17349
Misses 5542 5542
Partials 1028 1028 |
Member
Author
|
I'll work around this in #2473 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
It appears that we're publishing images to
mcr.microsoft.com/oss/kubernetes/now instead ofmcr.microsoft.com/k8s/core/. This changes that base URL in AKS Engine code to match.Issue Fixed:
Unblocks #2473
Requirements:
Notes:
It looks like this change will only affect
pause,cloud-node-manager, andcloud-controller-managerin practice. I've verified that all our expected images and tags are there at the new URL.