This repository was archived by the owner on Oct 24, 2023. It is now read-only.
accelerated networking rationalization, with tests#25
Merged
jackfrancis merged 2 commits intoAzure:masterfrom Nov 16, 2018
Merged
accelerated networking rationalization, with tests#25jackfrancis merged 2 commits intoAzure:masterfrom
jackfrancis merged 2 commits intoAzure:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 46.89% 46.89%
=======================================
Files 91 91
Lines 13800 13800
=======================================
Hits 6471 6471
Misses 6721 6721
Partials 608 608 |
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
* Kubernetes v1.8.4 support * added windows v1.8.4 artifact * release the kraken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Ensuring that the Windows implementation of accelerated networking also includes the guards against upgrade and scale, and actually added unit tests.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: