Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

refactor: remove SwarmMode/DockerCE orchestrator#2502

Closed
mboersma wants to merge 1 commit intoAzure:masterfrom
mboersma:remove-old-orchestrators-2
Closed

refactor: remove SwarmMode/DockerCE orchestrator#2502
mboersma wants to merge 1 commit intoAzure:masterfrom
mboersma:remove-old-orchestrators-2

Conversation

@mboersma
Copy link
Member

@mboersma mboersma commented Dec 23, 2019

Reason for Change:
Removes code supporting the SwarmMode/DockerCE orchestrator, as a first step toward removing all old orchestrator code in AKS Engine.

Issue Fixed:
Refs #2500

Requirements:

Notes:
This is still a size/XXL PR. Does it seem reviewable? Others may be of a similar size.

@mboersma
Copy link
Member Author

/hold

This is premature: I'm still waiting for feedback on #2500, we should wait until closer to the ACS end-of-life date, and it's the holiday season. 🎄

@acs-bot
Copy link

acs-bot commented Dec 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #2502 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
- Coverage    72.7%   72.57%   -0.14%     
==========================================
  Files         130      130              
  Lines       24105    24022      -83     
==========================================
- Hits        17526    17433      -93     
- Misses       5553     5566      +13     
+ Partials     1026     1023       -3

@mboersma
Copy link
Member Author

mboersma commented Jan 7, 2020

The word on the street is that ACS may receive a stay of execution, so the old orchestrator code may need to be preserved (if not updated...).

@mboersma mboersma closed this Jan 7, 2020
@mboersma mboersma deleted the remove-old-orchestrators-2 branch January 7, 2020 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants