This repository was archived by the owner on Oct 24, 2023. It is now read-only.
refactor: remove SwarmMode/DockerCE orchestrator#2502
Closed
mboersma wants to merge 1 commit intoAzure:masterfrom
Closed
refactor: remove SwarmMode/DockerCE orchestrator#2502mboersma wants to merge 1 commit intoAzure:masterfrom
mboersma wants to merge 1 commit intoAzure:masterfrom
Conversation
Member
Author
|
/hold This is premature: I'm still waiting for feedback on #2500, we should wait until closer to the ACS end-of-life date, and it's the holiday season. 🎄 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2502 +/- ##
==========================================
- Coverage 72.7% 72.57% -0.14%
==========================================
Files 130 130
Lines 24105 24022 -83
==========================================
- Hits 17526 17433 -93
- Misses 5553 5566 +13
+ Partials 1026 1023 -3 |
Member
Author
|
The word on the street is that ACS may receive a stay of execution, so the old orchestrator code may need to be preserved (if not updated...). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Removes code supporting the SwarmMode/DockerCE orchestrator, as a first step toward removing all old orchestrator code in AKS Engine.
Issue Fixed:
Refs #2500
Requirements:
Notes:
This is still a
size/XXLPR. Does it seem reviewable? Others may be of a similar size.