This repository was archived by the owner on Oct 24, 2023. It is now read-only.
fix: scale operation looks for windows name for linux pool#2638
Closed
jackfrancis wants to merge 2 commits intoAzure:masterfrom
Closed
fix: scale operation looks for windows name for linux pool#2638jackfrancis wants to merge 2 commits intoAzure:masterfrom
jackfrancis wants to merge 2 commits intoAzure:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2638 +/- ##
==========================================
- Coverage 71.83% 71.76% -0.08%
==========================================
Files 131 134 +3
Lines 24846 24999 +153
==========================================
+ Hits 17849 17941 +92
- Misses 5970 6008 +38
- Partials 1027 1050 +23 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
See #2643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR ensures we don't parse for a Windows name during scale operations unless we are running in the context of a Windows node pool.
This fixes a regression introduced in #2483
Issue Fixed:
Fixes #2637
Requirements:
Notes: