Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

fix: add package name for the constant#2928

Closed
ZeroMagic wants to merge 1 commit intoAzure:masterfrom
ZeroMagic:package_name
Closed

fix: add package name for the constant#2928
ZeroMagic wants to merge 1 commit intoAzure:masterfrom
ZeroMagic:package_name

Conversation

@ZeroMagic
Copy link
Contributor

@ZeroMagic ZeroMagic commented Mar 19, 2020

Reason for Change:

There is an error when making the master branch.

root@xxx:~/go/src/github.com/Azure/aks-engine# make
make -C hack/tools/
make[1]: Entering directory '/root/go/src/github.com/Azure/aks-engine/hack/tools'
GOBIN=/root/go/src/github.com/Azure/aks-engine/hack/tools/bin go get github.com/go-bindata/go-bindata/...@v3.1.2
go: finding github.com/go-bindata/go-bindata v3.1.2
GOBIN=/root/go/src/github.com/Azure/aks-engine/hack/tools/bin go get github.com/mitchellh/gox/...@v1.0.1
GOBIN=/root/go/src/github.com/Azure/aks-engine/hack/tools/bin go get github.com/onsi/ginkgo/ginkgo/...@v1.10.1
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b /root/go/src/github.com/Azure/aks-engine/hack/tools/bin v1.23.7
golangci/golangci-lint info checking GitHub for tag 'v1.23.7'
golangci/golangci-lint info found version: 1.23.7 for v1.23.7/linux/amd64
golangci/golangci-lint info installed /root/go/src/github.com/Azure/aks-engine/hack/tools/bin/golangci-lint
GOBIN=/root/go/src/github.com/Azure/aks-engine/hack/tools/bin go get github.com/devigned/pub/...@v0.2.0
make[1]: Leaving directory '/root/go/src/github.com/Azure/aks-engine/hack/tools'
go-bindata 3.1.2 (Go runtime go1.13.8).
Copyright (c) 2010-2013, Jim Teeuwen.
go generate -mod=vendor -v ./... > /dev/null 2>&1
go build -mod=vendor -ldflags '-s -X main.version=3e6b593c7d5e2878be2e536b62a596ad7e530ed7 -X github.com/Azure/aks-engine/pkg/telemetry.AKSEngineAppInsightsKey=c92d8284-b550-4b06-b7ba-e80fd7178faa -X github.com/Azure/aks-engine/pkg/test.JUnitOutDir=/root/go/src/github.com/Azure/aks-engine/test/junit -X github.com/Azure/aks-engine/cmd.BuildSHA=3e6b593c7 -X github.com/Azure/aks-engine/cmd.GitTreeState=clean -X github.com/Azure/aks-engine/cmd.BuildTag=canary' -o /root/go/src/github.com/Azure/aks-engine/bin/aks-engine
# github.com/Azure/aks-engine/pkg/api
pkg/api/types.go:1716:9: undefined: DefaultEnableCSIProxyWindows
note: module requires Go 1.14
Makefile:95: recipe for target 'go-build' failed
make: *** [go-build] Error 2

Issue Fixed:

Requirements:

Notes:

Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
@welcome
Copy link

welcome bot commented Mar 19, 2020

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@ZeroMagic
Copy link
Contributor Author

/cc @andyzhangx

@acs-bot acs-bot requested a review from andyzhangx March 19, 2020 03:52
@ZeroMagic ZeroMagic changed the title fix: add package name for the variable fix: add package name for the constant Mar 19, 2020
@andyzhangx
Copy link
Contributor

/azp run pr-e2e
this PR fixed the build break
/assign @jackfrancis

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Copy link
Contributor

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@andyzhangx
Copy link
Contributor

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@andyzhangx
Copy link
Contributor

/hold
hold for test running complete

@acs-bot
Copy link

acs-bot commented Mar 19, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andyzhangx, ZeroMagic
To complete the pull request process, please assign jackfrancis
You can assign the PR to them by writing /assign @jackfrancis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3e6b593). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #2928   +/-   ##
=========================================
  Coverage          ?   72.49%           
=========================================
  Files             ?      141           
  Lines             ?    25912           
  Branches          ?        0           
=========================================
  Hits              ?    18785           
  Misses            ?     6034           
  Partials          ?     1093

@andyzhangx
Copy link
Contributor

/hold cancel

@jackfrancis
Copy link
Member

Thanks @ZeroMagic, we reverted the breaking change!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants