This repository was archived by the owner on Oct 24, 2023. It is now read-only.
docs: add note on AKS-Engine and AKS relationship#293
Merged
CecileRobertMichon merged 1 commit intoAzure:masterfrom Jan 11, 2019
Merged
docs: add note on AKS-Engine and AKS relationship#293CecileRobertMichon merged 1 commit intoAzure:masterfrom
CecileRobertMichon merged 1 commit intoAzure:masterfrom
Conversation
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Contributor
Author
|
For context: #253 (comment) |
Contributor
|
/lgtm |
Contributor
|
note to self to also exclude the README from E2E |
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 53.22% 53.22%
=======================================
Files 95 95
Lines 14233 14233
=======================================
Hits 7575 7575
Misses 5993 5993
Partials 665 665 |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bacongobbler, CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
pushed a commit
that referenced
this pull request
Jan 11, 2019
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up on #253 based on one of @jackfrancis's feedback that somehow got lost in a rebase. Sorry!