fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo by AbelHu · Pull Request #2954 · Azure/aks-engine

AbelHu · 2020-03-24T03:37:42Z

Reason for Change:

Get WindowsVersion more efficiently.

Issue Fixed:

Fix #2946

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:

…Info

mboersma · 2020-03-24T15:02:43Z

/azp run pr-e2e

azure-pipelines · 2020-03-24T15:02:53Z

Azure Pipelines successfully started running 1 pipeline(s).

codecov · 2020-03-24T15:16:06Z

Codecov Report

Merging #2954 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2954   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         141      141           
  Lines       25934    25934           
=======================================
  Hits        18821    18821           
  Misses       6014     6014           
  Partials     1099     1099

Impacted Files	Coverage Δ
pkg/engine/templates_generated.go	`34.82% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6870bb...629f577. Read the comment docs.

marosset · 2020-03-25T17:25:46Z

/lgtm
Thanks @AbelHu!

acs-bot · 2020-03-25T17:28:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…Info (Azure#2954)

* chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790) * chore: update Azure CNI to v1.0.33 (#2825) * feat: collect Windows CSE logs during log collection (#2858) * fix: Windows no outbound fixes (#2883) * fix: fixing nssm logging in windows CSE (#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954) * feat: Updating AKS to use April 2020 Windows VHDs by default (#3060) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com> Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com>

* chore: adding azure-cni v1.0.33 artifacts to VHDs (Azure#2790) * chore: update Azure CNI to v1.0.33 (Azure#2825) * feat: collect Windows CSE logs during log collection (Azure#2858) * fix: Windows no outbound fixes (Azure#2883) * fix: fixing nssm logging in windows CSE (Azure#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (Azure#2954) * feat: Updating AKS to use April 2020 Windows VHDs by default (Azure#3060) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com> Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com>

* Upgrade Windows VHD image to April release (#3111) * chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790) * chore: update Azure CNI to v1.0.33 (#2825) * feat: collect Windows CSE logs during log collection (#2858) * fix: Windows no outbound fixes (#2883) * fix: fixing nssm logging in windows CSE (#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954) * feat: Updating AKS to use April 2020 Windows VHDs by default (#3060) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com> Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com> * feat: adding kubelet and csi-proxy-server as windows defender excluded processes (#2967) (#3118) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com> Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com>

…Info (Azure#2954)

* feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback * chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790) * chore: update Azure CNI to v1.0.33 (#2825) * feat: collect Windows CSE logs during log collection (#2858) * fix: Windows no outbound fixes (#2883) * fix: fixing nssm logging in windows CSE (#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954) * feat: adding kubelet and csi-proxy-server as windows defender excluded processes (#2967) * feat: Updating AKS to use April 2020 Windows VHDs by default (#3060) * feat: Updating Windows VHDs with 4B patches (#3115) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com> Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com>

fix: Get WindowsVersion from registry instead of calling Get-Computer…

629f577

…Info

acs-bot added the size/M label Mar 24, 2020

mboersma added the windows label Mar 24, 2020

mboersma requested a review from marosset March 25, 2020 17:14

acs-bot assigned marosset Mar 25, 2020

acs-bot added the lgtm label Mar 25, 2020

marosset approved these changes Mar 25, 2020

View reviewed changes

acs-bot added the approved label Mar 25, 2020

marosset merged commit 9a78964 into Azure:master Mar 25, 2020

fmotrifork mentioned this pull request Apr 14, 2020

aks-engine 0.49.0 fishworks/fish-food#678

Merged

AbelHu added a commit to AbelHu/aks-engine that referenced this pull request Apr 20, 2020

fix: Get WindowsVersion from registry instead of calling Get-Computer…

522a4a1

…Info (Azure#2954)

AbelHu added a commit to AbelHu/aks-engine that referenced this pull request Apr 21, 2020

fix: Get WindowsVersion from registry instead of calling Get-Computer…

f07cd5d

…Info (Azure#2954)

AbelHu mentioned this pull request Apr 22, 2020

Upgrade Windows VHD image to April release 17763.1098.200409 #3120

Closed

4 tasks

AbelHu mentioned this pull request Apr 22, 2020

Upgrade Windows VHD image to April release 17763.1098.200409 #3121

Merged

4 tasks

AbelHu added a commit to AbelHu/aks-engine that referenced this pull request Apr 23, 2020

fix: Get WindowsVersion from registry instead of calling Get-Computer…

a1250d0

…Info (Azure#2954)

AbelHu deleted the win_vhd_ver branch May 15, 2020 07:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo#2954

fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo#2954
marosset merged 1 commit intoAzure:masterfrom
AbelHu:win_vhd_ver

AbelHu commented Mar 24, 2020

Uh oh!

mboersma commented Mar 24, 2020

Uh oh!

azure-pipelines bot commented Mar 24, 2020

Uh oh!

codecov bot commented Mar 24, 2020

Uh oh!

marosset commented Mar 25, 2020

Uh oh!

acs-bot commented Mar 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AbelHu commented Mar 24, 2020

Uh oh!

mboersma commented Mar 24, 2020

Uh oh!

azure-pipelines bot commented Mar 24, 2020

Uh oh!

codecov bot commented Mar 24, 2020

Codecov Report

Uh oh!

marosset commented Mar 25, 2020

Uh oh!

acs-bot commented Mar 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants