This repository was archived by the owner on Oct 24, 2023. It is now read-only.
remove additional sed statements for ip-masq addons#30
Merged
jackfrancis merged 2 commits intoAzure:masterfrom Nov 19, 2018
Merged
remove additional sed statements for ip-masq addons#30jackfrancis merged 2 commits intoAzure:masterfrom
jackfrancis merged 2 commits intoAzure:masterfrom
Conversation
tariq1890
force-pushed
the
ip-masq-seds
branch
from
16c42f2 to
8ab1ba8
Compare
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 47.55% 47.55%
=======================================
Files 91 91
Lines 13974 13974
=======================================
Hits 6646 6646
Misses 6721 6721
Partials 607 607 |
tariq1890
force-pushed
the
ip-masq-seds
branch
from
8ab1ba8 to
a75a062
Compare
jackfrancis
reviewed
Nov 16, 2018
| - <nonmasqCNIIP> | ||
| masqLinkLocal: <masqLink> | ||
| - {{ContainerConfig "non-masquerade-cidr"}} | ||
| {{- if ContainerConfig "non-masq-cni-cidr"}} |
Member
There was a problem hiding this comment.
is the hyphen supposed to be here? {{-
Contributor
Author
There was a problem hiding this comment.
yes. It removes the preceding line break
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing additional sed statements for ip-masq-agent addon