Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

Templates end with .tmpl#31

Merged
mboersma merged 2 commits intoAzure:masterfrom
mboersma:templates-end-with-tmpl
Nov 16, 2018
Merged

Templates end with .tmpl#31
mboersma merged 2 commits intoAzure:masterfrom
mboersma:templates-end-with-tmpl

Conversation

@mboersma
Copy link
Member

@mboersma mboersma commented Nov 16, 2018

What this PR does / why we need it:

Changes the filename extension of template files from .t to .tmpl, which seems more standard in the Go ecosystem. Also cues GitHub's language detection to consider these files as Go (currently they are misdetected as Perl 6).

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Change the filename extension of template files from `.t` to `.tmpl`

@tariq1890
Copy link
Contributor

/lgtm

@jackfrancis
Copy link
Member

/lgtm pending E2E

@acs-bot
Copy link

acs-bot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma,tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   46.89%   46.89%           
=======================================
  Files          91       91           
  Lines       13800    13800           
=======================================
  Hits         6471     6471           
  Misses       6721     6721           
  Partials      608      608

@mboersma mboersma merged commit bd1f6b4 into Azure:master Nov 16, 2018
@mboersma mboersma deleted the templates-end-with-tmpl branch November 16, 2018 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants