This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Merged
Conversation
tariq1890
force-pushed
the
remove_az_const
branch
from
3897ca7 to
005a3ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 48.79% 48.79%
=======================================
Files 91 91
Lines 13859 13859
=======================================
Hits 6763 6763
Misses 6486 6486
Partials 610 610 |
tariq1890
force-pushed
the
remove_az_const
branch
from
005a3ac to
f0de7a4
Compare
tariq1890
force-pushed
the
remove_az_const
branch
from
f0de7a4 to
58da25c
Compare
Member
|
/lgtm |
Contributor
Author
|
@mboersma @CecileRobertMichon Thanks for the review. I have updated the PR with a non-breaking changes : New tests added. |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are removing unneeded methods in the azure const file. Code cleanup.