This repository was archived by the owner on Oct 24, 2023. It is now read-only.
enable /etc/hosts config agent for AKS private cluster BYO DNS#3585
Merged
xuto2 merged 1 commit intoAzure:aks-release-v0.47.0-1from Jul 9, 2020
Merged
enable /etc/hosts config agent for AKS private cluster BYO DNS#3585xuto2 merged 1 commit intoAzure:aks-release-v0.47.0-1from
xuto2 merged 1 commit intoAzure:aks-release-v0.47.0-1from
Conversation
…zure#3556) Co-authored-by: Li Ma <lima2@microsoft.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: levimm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
xuto2
reviewed
Jul 9, 2020
| echo "Updated $clusterFQDN to $clusterIP" | ||
| fi | ||
| sleep "${SLEEP_SECONDS}" | ||
| done |
Contributor
There was a problem hiding this comment.
please move this to a file when you make the cse change in agent baker
xuto2
reviewed
Jul 9, 2020
| Enabled *bool `json:"enabled,omitempty"` | ||
| JumpboxProfile *PrivateJumpboxProfile `json:"jumpboxProfile,omitempty"` | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
| EnableHostsConfigAgent *bool `json:"enableHostsConfigAgent,omitempty"` |
Contributor
There was a problem hiding this comment.
so you only need this line of change and the one in pkg/api/defaults.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#3556)
Co-authored-by: Li Ma lima2@microsoft.com
Reason for Change:
Issue Fixed:
Requirements:
Notes: